Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad behavior with "autocomplete" box #317

Closed
silverkorn opened this issue Apr 10, 2015 · 16 comments · Fixed by atom/atom#6572
Closed

Bad behavior with "autocomplete" box #317

silverkorn opened this issue Apr 10, 2015 · 16 comments · Fixed by atom/atom#6572

Comments

@silverkorn
Copy link

Using Atom 0.190.0 with autocomplete 0.44.0 and/or autocomplete-plus 2.9.0 + minimap 4.7.6 on Windows 7 64-bits.

Combining with official autocomplete or third-party autocomplete-plus, minimap push their box in the middle:

with-minimap

without-minimap

@abe33
Copy link
Contributor

abe33 commented Apr 13, 2015

Thanks for the report, I'll try to find a workaround so that we don't have to touch to autocomplete-plus but I fear that it won't be enough.

@silverkorn
Copy link
Author

All efforts are appreciated, thanks!

@tfausak
Copy link

tfausak commented Apr 16, 2015

👍 This affects me too.

@benogle
Copy link

benogle commented Apr 16, 2015

This might be a problem in core. Autocomplete uses the overlay decoration for positioning, and there are lot of size calcs going on in there...

@abe33
Copy link
Contributor

abe33 commented Apr 17, 2015

@benogle that was the conclusion I reached, I was planning to look at that.
Do you know if this kind of problem was reported for another package or is minimap the only package that attaches itself in the editor like that?

@benogle
Copy link

benogle commented Apr 17, 2015

I havent seen it anywhere else. I've added this to my autocomplete list, but might take me a bit to get to it.

@senditu
Copy link

senditu commented Apr 19, 2015

Yeah, I'm experiencing this too :(
But I'm pretty sure this only started happening recently, which is odd.

@lexicalunit
Copy link

👍 Seeing this too.

@mnquintana
Copy link

👍 I've been seeing this for a long time.

@benogle
Copy link

benogle commented Apr 29, 2015

Sorry, i'll look into this soon

@benogle
Copy link

benogle commented Apr 29, 2015

This is definitely a core issue. I'm computing the gutter width rather than measuring, which takes the minimap into account. Fixing now.

@benogle
Copy link

benogle commented Apr 29, 2015

A fix has been merged, and will be out in 0.195

@fundon
Copy link
Member

fundon commented Apr 29, 2015

Nice!

@abe33
Copy link
Contributor

abe33 commented Apr 30, 2015

Thank you @benogle!

I'll be waiting the release of 0.195 before closing this ticket then.

@silverkorn
Copy link
Author

Really nice to see that this module (and maybe many others) are watched by the core developers/contributors! 😃

@abe33
Copy link
Contributor

abe33 commented May 5, 2015

Ok, so I'm closing as 0.195 is out for some time now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants