Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError: Cannot read property 'getHeight' of null #193

Closed
postcasio opened this issue Jan 6, 2015 · 1 comment
Closed

Uncaught TypeError: Cannot read property 'getHeight' of null #193

postcasio opened this issue Jan 6, 2015 · 1 comment

Comments

@postcasio
Copy link
Contributor

With V4 enabled:

  1. Click and hold on the minimap to start dragging.
  2. Move the mouse down and outside the Atom window.
  3. Release the mouse button outside the window.
  4. Move the mouse back into the Atom window. The minimap continues to scroll when you move the mouse. (I expected this, since the minimap won't receive the mouseup event.) If you click in the editor at this point, the minimap goes back to normal and stops scrolling, but...
  5. If you click on the minimap, it gets stuck in the scrolling state.
  6. If you then close the editor, this error is thrown over and over again and Atom must be restarted.

Atom Version: 0.166.0
System: Mac OS X 10.10
Thrown From: minimap package, v3.5.0

Stack Trace

Uncaught TypeError: Cannot read property 'getHeight' of null

At /Users/dominic/.atom/packages/minimap/lib/minimap.coffee:86

TypeError: Cannot read property 'getHeight' of null
  at Minimap.module.exports.Minimap.getVisibleHeight (/Users/dominic/.atom/packages/minimap/lib/minimap.coffee:86:25)
  at atom-text-editor-minimap.MinimapElement.drag (/Users/dominic/.atom/packages/minimap/lib/minimap-element.coffee:379:27)
  at HTMLBodyElement.<anonymous> (/Users/dominic/.atom/packages/minimap/lib/minimap-element.coffee:366:32)

@abe33
Copy link
Contributor

abe33 commented Jan 6, 2015

Nice catch @postcasio 👍, I'll make sure to fix that for the next patch.

@abe33 abe33 closed this as completed in 8d026d1 Jan 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants