Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uncaught TypeError in dispatchResizeEndEvent on 3.4.4 #166

Closed
filipesilva opened this issue Dec 5, 2014 · 8 comments
Closed

Uncaught TypeError in dispatchResizeEndEvent on 3.4.4 #166

filipesilva opened this issue Dec 5, 2014 · 8 comments

Comments

@filipesilva
Copy link

I'm getting an error with today's update. This happens at least when I close opened files, but right now from opening and closing a couple of files on a new Atom instance I get some accumulated 60 of these errors.

They might originate in different lines but they always go back to dispatchResizeEndEvent.

Uncaught TypeError: Cannot read property 'style' of null minimap-view.coffee:368
module.exports.MinimapView.resetMinimapWidthWithWrap minimap-view.coffee:368
module.exports.MinimapView.updateMinimapWidthWithWrap minimap-view.coffee:345
module.exports.MinimapView.updateMinimapSize minimap-view.coffee:328
(anonymous function) minimap-view.coffee:1
module.exports.MinimapView.onScrollViewResized minimap-view.coffee:504
(anonymous function) minimap-view.coffee:1
dispatchResizeEndEvent
@fundon
Copy link
Member

fundon commented Dec 5, 2014

What's your atom version?
Latest atom 0.152 is ok on Mac.

@filipesilva
Copy link
Author

My apologies for the lack of system information. I am running Atom 0.152.0 on Windows 7. Later today I can test if it happens on Windows 8.1 also.

Closing the console also produces the error, which in turn opens the console again.

@abe33
Copy link
Contributor

abe33 commented Dec 5, 2014

Another issue with shadow DOM disabled... I'm on it

@filipesilva
Copy link
Author

Anything I can provide that would help?

@abe33
Copy link
Contributor

abe33 commented Dec 5, 2014

Nope, it's just that since Shadow DOM is going to be the default I forgot to test when the option is disabled, I could reproduce it and I have the patch ready.

@abe33 abe33 closed this as completed in 7d062ec Dec 5, 2014
@filipesilva
Copy link
Author

Damn that was fast, cheers :D

@abe33
Copy link
Contributor

abe33 commented Dec 5, 2014

For the record, it appears that when shadow DOM is enabled, the scrollbar is always reachable through querySelector when destroying the minimap, but not when shadow DOM is disabled.

@filipesilva
Copy link
Author

I'm getting another one which I guess is related. I'll open another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants