Uncaught TypeError: Cannot read property 'remove' of undefined #1997

SpaceLens · 2019-11-15T02:12:40Z

[Enter steps to reproduce:]

...
...

Atom: 1.40.1 x64
Electron: 3.1.10
OS: Ubuntu 18.04.3
Thrown From: script package 3.25.0

Stack Trace

Uncaught TypeError: Cannot read property 'remove' of undefined

At /home/paul/.atom/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189

TypeError: Cannot read property 'remove' of undefined
    at ScriptView.MessagePanelView.remove (/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:189:30)
    at ScriptView.detach (/packages/open-in-browsers/node_modules/jquery/dist/jquery.js:5357:15)
    at ScriptView.removePanel (/packages/script/lib/script-view.js:89:10)
    at Object.closeScriptViewAndStopRunner (/packages/script/lib/script.js:161:21)
    at HTMLElement.scriptCloseView (/packages/script/lib/script.js:94:39)
    at CommandRegistry.handleCommandEvent (/usr/share/atom/resources/app/static/<embedded>:11:349123)
    at CommandRegistry.dispatch (/usr/share/atom/resources/app/static/<embedded>:11:347598)
    at ScriptView.close (/packages/script/lib/script-view.js:99:19)
    at /packages/open-in-browsers/node_modules/space-pen/lib/space-pen.js:220:36)
    at HTMLDivElement.dispatch (/packages/open-in-browsers/node_modules/jquery/dist/jquery.js:4435:9)
    at HTMLDivElement.elemData.handle (/packages/open-in-browsers/node_modules/jquery/dist/jquery.js:4121:28)

Commands

  4x -0:24.8.0 core:save (input.hidden-input)
     -0:22.7.0 core:close (input.hidden-input)
     -0:22 editor:consolidate-selections (input.hidden-input)
     -0:22 core:cancel (input.hidden-input)
     -0:21.4.0 editor:consolidate-selections (input.hidden-input)
     -0:21.4.0 core:cancel (input.hidden-input)
     -0:21.2.0 editor:consolidate-selections (input.hidden-input)
     -0:21.2.0 core:cancel (input.hidden-input)
     -0:21.1.0 editor:consolidate-selections (input.hidden-input)
     -0:21.1.0 core:cancel (input.hidden-input)
     -0:20.9.0 editor:consolidate-selections (input.hidden-input)
     -0:20.9.0 core:cancel (input.hidden-input)
     -0:20.7.0 editor:consolidate-selections (input.hidden-input)
     -0:20.7.0 core:cancel (input.hidden-input)
     -0:14.3.0 core:close (atom-pane.pane.active)
     -0:05.7.0 script:close-view (atom-workspace.workspace.scrollbars-visible-always.theme-one-dark-syntax.theme-one-dark-ui)

Non-Core Packages

emmet 2.4.3 
open-in-browsers 0.0.30 
script 3.25.0

The text was updated successfully, but these errors were encountered:

vsharm29 · 2019-11-15T07:32:28Z

when ever I try to run my code by pressing keys ctrl + shift + B. The down pane opens up and shows output of the code. When ever I try to close the pane it raises an error. Please look into this issue, it's very irritating.

Pixel48 · 2019-11-15T18:29:05Z

Im trying to fix this, but for know fou can use ctrl-shift-f5. And i know, it's not solution

when ever I try to run my code by pressing keys ctrl + shift + B. The down pane opens up and shows output of the code. When ever I try to close the pane it raises an error. Please look into this issue, it's very irritating.

JordanTheDodger · 2019-11-17T14:12:24Z

I am getting the same error. It was fine until yesterday. I think there is something wrong with the library that deals with MessagePanelView

shreyasgaonkar · 2019-11-18T12:43:05Z

This shows up on other keyboard shortcuts not dealing with the module as well. Not able to close active tabs using cmd + w is really annoying

MacOS: Mojave 10.14.6 (18G103)
Atom: 1.40.1 x64

Talon24 · 2019-11-18T15:31:20Z

When the output pane is stuck already, i also get an error thrown when I press ESC

VinnieM · 2019-11-19T03:23:57Z

This same issue is happening in Mac OS as well.
Atom: 1.41.0
OS : Catalina 10.15.1.

xumang · 2019-11-19T11:49:17Z

The same error occurs when I try to kill this process.
Atom 1.41.0 x64，win10

mkrd · 2019-11-20T14:08:24Z

Same issue here

This same issue is happening in Mac OS as well.
Atom: 1.41.0
OS : Catalina 10.15.1.

creativecag · 2019-11-20T17:48:34Z

+1

tswinb · 2019-11-21T11:38:28Z

Same issue here. Windows 10, Atom 1.41.0 x64

Callum-25252 · 2019-11-21T17:30:22Z

I have the same issue, also occurs when I press ESC or use CTRL+W. Ubuntu 18.04, Atom 1.40.0

fdq09eca · 2019-11-23T03:57:52Z

same with @AStartledRaccoon

medardm · 2019-11-23T17:58:13Z

Still no solution to this issue? :(

medardm · 2019-11-25T05:16:50Z

Here's a temporary solution. Modify function in line 187 under
.atom\packages\script\node_modules\atom-message-panel\lib\MessagePanelView.js
from

MessagePanelView.prototype.remove = function (index) {
  this.messages.splice(-index, 1);
  this.body.children()[index].remove();
};

to:

MessagePanelView.prototype.remove = function (index) {
  $('.native-key-bindings.script-view').remove();
};

Callum-25252 · 2019-11-25T11:46:30Z

@medardm 's solution worked for me!

medardm · 2019-11-25T11:56:49Z

@AStartledRaccoon I'm glad it worked. :)

raffaeleGrandi · 2019-11-26T09:44:02Z

It works also for me thanks

Brolly0204 · 2019-12-01T03:18:25Z

[Enter steps to reproduce:]

...
...

Atom: 1.41.0 x64
Electron: 4.2.7
OS: Mac OS X 10.15
Thrown From: script package 3.25.0

Stack Trace

Uncaught TypeError: Cannot read property 'remove' of undefined

At /Users/jasonli/.atom/packages/script/node_modules/atom-message-panel/lib/MessagePanelView.js:188

Sirfanas · 2019-12-02T14:10:26Z

Thank's @medardm for the fix !
Maybe you could made a pull request to include it ?

medardm · 2019-12-03T13:41:40Z

I will when I find a long term solution. Because the solution I introduced was an adjustment with one of the dependencies, not with the actual package.

kimathie · 2019-12-04T13:55:49Z

When I press escape and or try to close the output panel I get this error.

rifusaki · 2019-12-06T01:46:18Z

@medardm Could you tell us which dependecy you used? So we can use your fix. Thanks!

VinnieM · 2019-12-06T07:31:03Z

@medardm Thanks for the fix!!!

kimathie · 2019-12-06T08:00:08Z

@medardm thanks I hadn't seen that solution. It works

ghost · 2019-12-07T15:00:16Z

same issue here, please fix it!
Windows 10 | Atom 1.41.0 x64

medardm · 2019-12-09T06:25:31Z

@CharaDraemurr I didn't change any of the dependencies, just modified a line of code on one of the dependencies of this package, but this is not a long term solution.

Here's a temporary solution. Modify function in line 187 under
.atom\packages\script\node_modules\atom-message-panel\lib\MessagePanelView.js
from
MessagePanelView.prototype.remove = function (index) {
  this.messages.splice(-index, 1);
  this.body.children()[index].remove();
};
to:
MessagePanelView.prototype.remove = function (index) {
  $('.native-key-bindings.script-view').remove();
};

ghost · 2019-12-10T18:47:44Z

Just downloaded this package and found this bug, please fix it!

medardm · 2019-12-11T06:35:35Z

@Fellox . There's already a PR to fix this issue (#2004). You can review it on your side. I already checked it and it works

DeathGOD7 · 2019-12-22T11:15:25Z

Here's a temporary solution. Modify function in line 187 under
.atom\packages\script\node_modules\atom-message-panel\lib\MessagePanelView.js
from
MessagePanelView.prototype.remove = function (index) {
  this.messages.splice(-index, 1);
  this.body.children()[index].remove();
};
to:
MessagePanelView.prototype.remove = function (index) {
  $('.native-key-bindings.script-view').remove();
};

That is the solution for now. Thanks for it. :)

hex0x42424242 · 2020-02-05T20:38:48Z

nice bro, works for me.
Thanks!

jakelevifulfil · 2020-02-05T21:10:57Z

This hasn't worked for me :(

Also, editing the files seems to have no effect, even if I intentionally add syntax errors or just comment out the code. I'm looking in <Username>\.atom\packages\script\node_modules\atom-message-panel\lib.

creativecag · 2020-02-06T15:30:29Z

This hasn't worked for me :(

Also, editing the files seems to have no effect, even if I intentionally add syntax errors or just comment out the code. I'm looking in <Username>\.atom\packages\script\node_modules\atom-message-panel\lib.

I had a similar problem. Gave up on it for now.

junepark6 · 2020-02-07T18:35:39Z

I also still have this issue. Panel could be removed after modifying the source as you suggested, but it was only working one time. I mean, if I removed the panel before and run again the script, then I cannot remove the panel.

wesgt · 2020-02-11T16:41:26Z

@junepark6 I had a similar problem. But follow below to make changes and it worked for me.

go to .atom\packages\script\node_modules\atom-message-panel\lib\MessagePanelView.js

MessagePanelView.prototype.remove = function (index) {
  this.messages.splice(-index, 1);
  this.body.children().remove(index);
};

creativecag · 2020-02-17T17:21:34Z

@wesgt That appears to have worked for me as well. Thanks!

jakelevifulfil · 2020-02-18T19:13:22Z

It fixed itself for me... Didn't make any changes, but all's good now! :)

mavericks52 · 2020-02-25T21:36:07Z

@wesgt I now have a problem after your fix where i cant run the program after i close the script window

lazerbolt390 · 2020-03-23T09:59:10Z

@wesgt thanks!

pfandzelter mentioned this issue Dec 10, 2019

fix atom-message-panel bug (error on message-panel/window close) #2004

Merged

pfandzelter mentioned this issue Dec 16, 2019

Uncaught TypeError: Cannot read property 'remove' of undefined #2006

Open

ubiq-x mentioned this issue Feb 4, 2020

Uncaught TypeError: Cannot read property 'remove' of undefined #2038

Closed

julibeg mentioned this issue Mar 4, 2020

Uncaught TypeError: Cannot read property 'remove' of undefined #2066

Closed

aminya added the duplicate label Dec 30, 2020

aminya closed this as completed Dec 30, 2020

Uncaught TypeError: Cannot read property 'remove' of undefined #1997

Uncaught TypeError: Cannot read property 'remove' of undefined #1997

Comments

SpaceLens commented Nov 15, 2019

Stack Trace

Commands

Non-Core Packages

vsharm29 commented Nov 15, 2019

Pixel48 commented Nov 15, 2019

JordanTheDodger commented Nov 17, 2019

shreyasgaonkar commented Nov 18, 2019 • edited Loading

Talon24 commented Nov 18, 2019 • edited Loading

VinnieM commented Nov 19, 2019

xumang commented Nov 19, 2019

mkrd commented Nov 20, 2019

creativecag commented Nov 20, 2019

tswinb commented Nov 21, 2019

Callum-25252 commented Nov 21, 2019 • edited Loading

fdq09eca commented Nov 23, 2019

medardm commented Nov 23, 2019

medardm commented Nov 25, 2019 • edited Loading

Callum-25252 commented Nov 25, 2019

medardm commented Nov 25, 2019

raffaeleGrandi commented Nov 26, 2019

Brolly0204 commented Dec 1, 2019

Stack Trace

Sirfanas commented Dec 2, 2019

medardm commented Dec 3, 2019

kimathie commented Dec 4, 2019

rifusaki commented Dec 6, 2019

VinnieM commented Dec 6, 2019

kimathie commented Dec 6, 2019

ghost commented Dec 7, 2019

medardm commented Dec 9, 2019 • edited Loading

ghost commented Dec 10, 2019

medardm commented Dec 11, 2019

DeathGOD7 commented Dec 22, 2019

hex0x42424242 commented Feb 5, 2020

jakelevifulfil commented Feb 5, 2020

creativecag commented Feb 6, 2020

junepark6 commented Feb 7, 2020

wesgt commented Feb 11, 2020 • edited Loading

creativecag commented Feb 17, 2020

jakelevifulfil commented Feb 18, 2020

mavericks52 commented Feb 25, 2020

lazerbolt390 commented Mar 23, 2020

shreyasgaonkar commented Nov 18, 2019 •

edited

Loading

Talon24 commented Nov 18, 2019 •

edited

Loading

Callum-25252 commented Nov 21, 2019 •

edited

Loading

medardm commented Nov 25, 2019 •

edited

Loading

medardm commented Dec 9, 2019 •

edited

Loading

wesgt commented Feb 11, 2020 •

edited

Loading