From 245c42a794d71be9107b83b10a0dc41f6c8cb1de Mon Sep 17 00:00:00 2001 From: atlowChemi Date: Wed, 2 Aug 2023 19:36:51 +0300 Subject: [PATCH] test: stabilize the inspector-open-dispose test Ref: https://ci.nodejs.org/job/node-test-commit-osx-arm/nodes\=osx11/12543/console, https://github.com/nodejs/reliability/issues/631 --- test/parallel/test-inspector-open-dispose.mjs | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/test/parallel/test-inspector-open-dispose.mjs b/test/parallel/test-inspector-open-dispose.mjs index e562535e1a0fc9d..ef6e436bfcd4d4c 100644 --- a/test/parallel/test-inspector-open-dispose.mjs +++ b/test/parallel/test-inspector-open-dispose.mjs @@ -8,37 +8,31 @@ common.skipIfInspectorDisabled(); if (process.env.BE_CHILD) { await beChild(); } else { - let firstPort; - const filename = url.fileURLToPath(import.meta.url); const child = fork(filename, { env: { ...process.env, BE_CHILD: 1 } }); child.once('message', common.mustCall((msg) => { assert.strictEqual(msg.cmd, 'started'); + assert.strictEqual(msg.url, undefined); - child.send({ cmd: 'open', args: [] }); + child.send({ cmd: 'open' }); child.once('message', common.mustCall(wasOpenedHandler)); })); function wasOpenedHandler(msg) { assert.strictEqual(msg.cmd, 'url'); - const port = url.parse(msg.url).port; + const { port } = url.parse(msg.url); ping(port, common.mustSucceed(() => { - // Inspector is already open, and won't be reopened, so args don't matter. child.send({ cmd: 'dispose' }); child.once('message', common.mustCall(wasDisposedWhenOpenHandler)); - firstPort = port; })); } - function wasDisposedWhenOpenHandler(msg) { + async function wasDisposedWhenOpenHandler(msg) { assert.strictEqual(msg.cmd, 'url'); assert.strictEqual(msg.url, undefined); - ping(firstPort, (err) => { - assert(err); - child.send({ cmd: 'dispose' }); - child.once('message', common.mustCall(wasReDisposedHandler)); - }); + child.send({ cmd: 'dispose' }); + child.once('message', common.mustCall(wasReDisposedHandler)); } function wasReDisposedHandler(msg) {