fix: droppable-get-dimension withScroll #966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexreardon kindly pls take a look at the pull request |
|
Away this week. Will look next week
…On Thu, 29 Nov 2018 at 9:02 pm, woohling ***@***.***> wrote:
@alexreardon <https://github.com/alexreardon> kindly pls take a look at
the pull request
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#966 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACFN7bVEmifeJivo-8B-J-jOZ2eUaBl5ks5uz7CYgaJpZM4Y2taj>
.
|
alexreardon
reviewed
Dec 2, 2018
| @@ -117,7 +117,7 @@ export default ({ | |||
|
|
|||
| return { | |||
| client: frameClient, | |||
| page: withScroll(frameClient), | |||
There was a problem hiding this comment.
withScroll will apply the page scroll
There was a problem hiding this comment.
You are right that your change is a bit stricter in that it does not read the page scroll directly, but just supplies it..
Thoughts?
There was a problem hiding this comment.
I would prefer the more strict method, it may cause potential bug which I encountered.
There was a problem hiding this comment.
I also like that this approach does not touch the DOM again and just uses the value that has been passed in
alexreardon
approved these changes
Dec 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're forking your amazing repo and need to add some features based on our product logic, and then I found a potential bug, which I spent a lot of time debuging.
The default container supporting horizontal scroll is the window, which would not trigger any bugs currently. But I think it would be stricter to code it this way. Pls take a look and see if I'm doing this correctly.