hook functions are now called after the reducer #618

alexreardon · 2018-07-04T22:19:31Z

Fixes #617

alexreardon · 2018-07-04T22:37:51Z

src/view/draggable/draggable.jsx

@@ -115,15 +117,6 @@ export default class Draggable extends Component<Props> {
    this.ref = null;
  }

-  // This should already be handled gracefully in DragHandle.


this is already taken care of inside of the drag-handle and the reducer

alexreardon · 2018-07-04T22:38:43Z

This brings the behaviour back in line with previous versions

alexreardon commented Jul 4, 2018

View reviewed changes

core change

2c63e97

alexreardon force-pushed the hook-timings branch from 2d6465a to 2c63e97 Compare July 4, 2018 23:01

alexreardon added investigating 🕵️‍♂️ and removed investigating 🕵️‍♂️ labels Jul 4, 2018

alexreardon merged commit 8bf03cc into master Jul 5, 2018

alexreardon deleted the hook-timings branch July 5, 2018 00:35

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hook functions are now called after the reducer #618

hook functions are now called after the reducer #618

alexreardon commented Jul 4, 2018

alexreardon Jul 4, 2018

alexreardon commented Jul 4, 2018

hook functions are now called after the reducer #618

hook functions are now called after the reducer #618

Conversation

alexreardon commented Jul 4, 2018

alexreardon Jul 4, 2018

Choose a reason for hiding this comment

alexreardon commented Jul 4, 2018