-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading deps #446
Upgrading deps #446
Changes from 10 commits
1fdd5d7
9a1f2af
994e463
7ed54a4
35aa95c
532f589
d6495e2
75ab753
496a762
54e8695
8aaa7f3
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,21 +1,21 @@ | ||
{ | ||
"dist/react-beautiful-dnd.js": { | ||
"bundled": 372683, | ||
"minified": 142833, | ||
"gzipped": 40327 | ||
"bundled": 399839, | ||
"minified": 149239, | ||
"gzipped": 42623 | ||
}, | ||
"dist/react-beautiful-dnd.min.js": { | ||
"bundled": 334038, | ||
"minified": 126662, | ||
"gzipped": 35556 | ||
"bundled": 358155, | ||
"minified": 132319, | ||
"gzipped": 37652 | ||
}, | ||
"dist/react-beautiful-dnd.esm.js": { | ||
"bundled": 176840, | ||
"minified": 88989, | ||
"gzipped": 22594, | ||
"bundled": 176656, | ||
"minified": 88917, | ||
"gzipped": 22577, | ||
"treeshaked": { | ||
"rollup": 77631, | ||
"webpack": 79229 | ||
"rollup": 77471, | ||
"webpack": 79091 | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,21 +44,22 @@ | |
}, | ||
"dependencies": { | ||
"babel-runtime": "^6.26.0", | ||
"invariant": "^2.2.4", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. gone!!! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I wrote my own. I will put it on npm soon. |
||
"memoize-one": "^3.1.1", | ||
"prop-types": "^15.6.0", | ||
"raf-schd": "^2.1.1", | ||
"react-motion": "^0.5.2", | ||
"react-redux": "^5.0.6", | ||
"redux": "^3.7.2", | ||
"redux-thunk": "^2.2.0", | ||
"reselect": "^3.0.1" | ||
"reselect": "^3.0.1", | ||
"tiny-invariant": "^0.0.3" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. right now i have not figured out how to get our rollup build to tree shake the env conditional insight of this module. However, i am happy to solve that later |
||
}, | ||
"devDependencies": { | ||
"@atlaskit/css-reset": "^2.0.0", | ||
"@storybook/react": "^3.2.16", | ||
"@storybook/react": "^3.4.1", | ||
"babel-cli": "^6.26.0", | ||
"babel-eslint": "^8.2.1", | ||
"babel-core": "^6.26.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No babel-core before this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it was being brought in by another dep. now we are being more explicit |
||
"babel-eslint": "^8.2.3", | ||
"babel-plugin-transform-class-properties": "^6.24.1", | ||
"babel-plugin-transform-es2015-modules-commonjs": "^6.26.0", | ||
"babel-plugin-transform-export-extensions": "^6.22.0", | ||
|
@@ -67,33 +68,33 @@ | |
"babel-preset-env": "^1.6.1", | ||
"babel-preset-flow": "^6.23.0", | ||
"babel-preset-react": "^6.24.1", | ||
"cross-env": "^5.1.3", | ||
"cross-env": "^5.1.4", | ||
"enzyme": "^3.3.0", | ||
"enzyme-adapter-react-16": "^1.1.1", | ||
"eslint": "^4.15.0", | ||
"eslint": "^4.19.1", | ||
"eslint-config-airbnb": "^16.1.0", | ||
"eslint-plugin-flowtype": "^2.41.0", | ||
"eslint-plugin-import": "^2.8.0", | ||
"eslint-plugin-jest": "^21.6.1", | ||
"eslint-plugin-flowtype": "^2.46.2", | ||
"eslint-plugin-import": "^2.11.0", | ||
"eslint-plugin-jest": "^21.15.0", | ||
"eslint-plugin-jsx-a11y": "^6.0.3", | ||
"eslint-plugin-react": "^7.5.1", | ||
"flow-bin": "0.69.0", | ||
"jest": "^22.0.5", | ||
"puppeteer": "^1.2.0", | ||
"eslint-plugin-react": "^7.7.0", | ||
"flow-bin": "0.70.0", | ||
"jest": "^22.4.3", | ||
"puppeteer": "^1.3.0", | ||
"raf-stub": "^2.0.2", | ||
"react": "^16.3.1", | ||
"react-dom": "^16.3.1", | ||
"react-test-renderer": "^16.3.1", | ||
"rimraf": "^2.6.2", | ||
"rollup": "^0.56.2", | ||
"rollup": "^0.58.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. could this be the cause? |
||
"rollup-plugin-babel": "^3.0.3", | ||
"rollup-plugin-commonjs": "^8.2.6", | ||
"rollup-plugin-node-resolve": "^3.0.2", | ||
"rollup-plugin-replace": "^2.0.0", | ||
"rollup-plugin-size-snapshot": "^0.3.0", | ||
"rollup-plugin-strip": "^1.1.1", | ||
"rollup-plugin-uglify": "^2.0.1", | ||
"styled-components": "^3.2.0" | ||
"styled-components": "^3.2.5" | ||
}, | ||
"peerDependencies": { | ||
"react": "^16.3.1" | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -134,10 +134,11 @@ export const scrollDroppable = ( | |
clipped, | ||
}; | ||
|
||
return ({ | ||
const result: DroppableDimension = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does flow complain without this cast? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nope! it now works with exact types and spread |
||
...droppable, | ||
viewport, | ||
}: any); | ||
}; | ||
return result; | ||
}; | ||
|
||
type GetDroppableArgs = {| | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -266,13 +266,13 @@ export default (state: State = clean('IDLE'), action: Action): State => { | |
return existing; | ||
} | ||
|
||
const newDrag: DragState = ({ | ||
const newDrag: DragState = { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could clean up the Flow annotations by typing this IIFE like: const drag = ((): ?DragState => {
// ...
})(); |
||
...existing, | ||
current: { | ||
...existing.current, | ||
hasCompletedFirstBulkPublish: true, | ||
}, | ||
}: any); | ||
}; | ||
|
||
return newDrag; | ||
})(); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -364,15 +364,15 @@ export type DropState = {| | |
result: ?DropResult, | ||
|} | ||
|
||
export type State = { | ||
export type State = {| | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. now an exact type |
||
phase: Phase, | ||
dimension: DimensionState, | ||
// null if not dragging | ||
drag: ?DragState, | ||
|
||
// available when dropping or cancelling | ||
drop: ?DropState, | ||
}; | ||
|}; | ||
|
||
export type Action = ActionCreators; | ||
export type Dispatch = ReduxDispatch<Action>; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
our esm builds are looking better for moving to invariant rather than throwing, but otherwise we took a huge hit!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the reason for using invariant over
throw
statements? Did you notice any effect on Flow's ability to narrow the types on things?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the reason for using invariant:
Flow understands that invariant will throw if the condition is not met