Provide cjs and esm bundles with information about treeshakability #429
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -9,9 +9,7 @@ node_modules/ | |
| .DS_Store | ||
|
|
||
| # generated files | ||
| dist/ | ||
|
|
||
| # generated site | ||
| site/ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,21 @@ | ||
| { | ||
| "dist/react-beautiful-dnd.min.js": { | ||
| "bundled": 331396, | ||
| "minified": 125563, | ||
| "gzipped": 35116 | ||
| }, | ||
| "dist/react-beautiful-dnd.umd.js": { | ||
| "bundled": 362816, | ||
| "minified": 135326, | ||
| "gzipped": 38147 | ||
| }, | ||
| "dist/react-beautiful-dnd.esm.js": { | ||
| "bundled": 167329, | ||
| "minified": 81581, | ||
| "gzipped": 20552, | ||
| "treeshaked": { | ||
| "rollup": 70346, | ||
| "webpack": 71950 | ||
| } | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,10 +8,14 @@ import replace from 'rollup-plugin-replace'; | |
| import strip from 'rollup-plugin-strip'; | ||
| import { sizeSnapshot } from 'rollup-plugin-size-snapshot'; | ||
|
|
||
| const pkg = require('./package.json'); | ||
|
|
||
| const input = './src/index.js'; | ||
|
|
||
| const extensions = ['.js', '.jsx']; | ||
|
|
||
| const isExternal = id => !id.startsWith('.') && !id.startsWith('/'); | ||
|
There was a problem hiding this comment. can you please add a comment above this line in the code explaining its purpose? Other than that I think I am good to go! |
||
|
|
||
| const getBabelOptions = () => ({ | ||
| exclude: 'node_modules/**', | ||
| runtimeHelpers: true, | ||
|
|
@@ -47,6 +51,36 @@ const getUMDConfig = ({ env, file }) => { | |
| }; | ||
|
|
||
| export default [ | ||
| getUMDConfig({ env: 'development', file: 'dist/react-beautiful-dnd.umd.js' }), | ||
|
|
||
| getUMDConfig({ env: 'production', file: 'dist/react-beautiful-dnd.min.js' }), | ||
|
There was a problem hiding this comment. This will break pattern :( I just would like to see this pattern widespread, so |
||
|
|
||
| { | ||
| input, | ||
| output: { | ||
| file: pkg.main, | ||
| format: 'cjs', | ||
| }, | ||
| external: isExternal, | ||
| plugins: [ | ||
| resolve({ extensions }), | ||
| babel(getBabelOptions()), | ||
| strip({ debugger: true }), | ||
| ], | ||
| }, | ||
|
|
||
| { | ||
| input, | ||
| output: { | ||
| file: pkg.module, | ||
| format: 'es', | ||
| }, | ||
| external: isExternal, | ||
| plugins: [ | ||
| resolve({ extensions }), | ||
| babel(getBabelOptions()), | ||
| strip({ debugger: true }), | ||
|
There was a problem hiding this comment. I am keen to keep console.* statements for the non-minified builds. Can the There was a problem hiding this comment. From non minified umd too? It seems console was always stripped from both umd bundles |
||
| sizeSnapshot({ updateSnapshot: !checkSnapshot }), | ||
| ], | ||
| }, | ||
| ]; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it common to do this rather than use a seperate folder?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dumb question, but cjs = CommonJS? 😊
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is not necessary to create a folder for only one file in it. We have five file in the end which look very nice in one folder.
Yes, esm and cjs are the most popular shorthands.