Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improving the screen reader guide #404

Merged
merged 3 commits into from
Mar 29, 2018
Merged

Conversation

alexreardon
Copy link
Collaborator

No description provided.

@alexreardon alexreardon self-assigned this Mar 23, 2018

### Drop in the home list
**Default message**: "You have dropped the item. It has moved from position `${result.source.index + 1}` to `${result.destination.index + 1}`"

This announcement should:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this line if we've got "We tell the user the following:" below? I'd get rid of it.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I must have missed this. I'll remove it

Copy link

@KarenBywater KarenBywater left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good Alex - I think it's good to go. I'm new to reviewing PRs, so I'm not sure about formatting etc, but the words sounds good and I let one comment about a line I think we need to ditch.

@alexreardon alexreardon merged commit bbec4c9 into master Mar 29, 2018
@alexreardon alexreardon deleted the improved-screen-reader-guide branch March 29, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants