Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a multi drag pattern #383

Merged
merged 20 commits into from
Mar 13, 2018
Merged

Adding a multi drag pattern #383

merged 20 commits into from
Mar 13, 2018

Conversation

alexreardon
Copy link
Collaborator

No description provided.

@alexreardon alexreardon requested a review from Blasz March 12, 2018 23:39
@@ -0,0 +1,232 @@
// @flow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see this file being imported anywhere, is it being used?

// When ordering the collected tasks:
// dragged item first
// followed by the items with the lowest index
// in the event of a tie, use the one that was selected first
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this order comment be located closer to the collection.sort line?

source,
destination,
}): Result => {
// 1. remove all of the selected tasks from their lists
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only numbered comment in the function. Should we remove the number or add some to the other comments?

};
};

export const reorderBetweenColumns = (args: Args): Result => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't this function reorder tasks in the same column as well? Is there a better name for this?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mutliDragAwareReorder seems alright for now

@alexreardon alexreardon merged commit 828be4a into master Mar 13, 2018
@alexreardon alexreardon deleted the multi-drag-3 branch March 13, 2018 06:29
@LuoweiC
Copy link

LuoweiC commented Mar 14, 2018

I want to use this,but i can't use,can you give me some guidance?

@alexreardon alexreardon mentioned this pull request Mar 23, 2018
@teksrc
Copy link

teksrc commented Mar 14, 2019

@LuoweiC What specifically about it can you not use. May you provide some specific issues you are dealing with?

I've been able to recreate a multi drag supported task list in my own open source repository by using the src code story from here if that may assist I can link it.

@geobde
Copy link

geobde commented Jun 30, 2019

@Frankcarvajal can you provide an example?

@teksrc
Copy link

teksrc commented Jul 2, 2019

@geobde I've got an example repository on my GitHub, but it doesn't have an example of a multi drag and drop table, just standard like an example. @alexreardon has no multi drag and drop table example and the issue I put in for this assigned to me, I've not had a moment to work on. I do wish he would put an example of it up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants