Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made timeForLongPress configurable #1856

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

spiritsack
Copy link

@spiritsack spiritsack commented Jun 5, 2020

This PR adds a new optional prop to Draggable, timeForLongPress, which by default is 120.

@atlassian-cla-bot
Copy link

atlassian-cla-bot bot commented Jun 5, 2020

Hooray! All contributors have signed the CLA.

@alexanderzone
Copy link

thank GabeN

@MaciejCaputa
Copy link

@alexreardon
Is there any impediment why it cannot be merged?

This is a deal breaker for my use case and crucial for me to have this released.

@mog3n
Copy link

mog3n commented Oct 30, 2020

Can we get this merged?

@amuhammed
Copy link

Any idea when this will be merged?

@d3x42
Copy link

d3x42 commented May 11, 2021

@alexreardon @danieldelcore Any chance to have it merged?

@danieldelcore
Copy link
Collaborator

Hey folks, will look at this today. Thanks for raising it with me 🙏

I'm still finding my feet so will need to do some digging to understand the context first. Changes look good to me though.

@mlshv
Copy link

mlshv commented Jul 26, 2021

Ping. Can we merge this finally? @danieldelcore

@mlshv
Copy link

mlshv commented Sep 8, 2021

Hi @danieldelcore!

Sorry for the inconvenience, but is there any chance this would be merged someday?

@tsiory
Copy link

tsiory commented Sep 16, 2021

Hi @danieldelcore,

Can you merge this PR please ?

Thanks in advance.

@kristoffersaastadold
Copy link

kristoffersaastadold commented Dec 3, 2021

Hi @danieldelcore,

Sorry for the ping.

I see that the PR has successfully passed all checks, is this being merged in the near future?

Thanks in advance :D

@d3x42
Copy link

d3x42 commented Dec 3, 2021

@kristoffersaastad Unfortunately Atlassian stops checking PRs for this library. You could find details in readme.md

@kristoffersaastadold
Copy link

@d3x42 Thank you for the fast reply! I see. Do you know if this or a similar functionality has been implemented or will be implemented in the near future? This issue is mostly concerning our iPad users.

@d3x42
Copy link

d3x42 commented Dec 3, 2021

@kristoffersaastad I don't think so. Probably I'll consider replacing this library with alternate solutions for our project.

@jariendeau
Copy link

Can we get a status update on this? Or just hit the merge button? ;)

@immortalt
Copy link

Can we get this merged?

@lsimonar
Copy link

lsimonar commented Apr 7, 2023

Could this be merged? Really important for my project too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.