fixing nested touch dragging #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
commented
Nov 15, 2017
| @@ -216,6 +222,11 @@ export const makeSelector = (): Selector => { | |||
| }; | |||
| } | |||
|
|
|||
| // a lift is in progress - do not let anything start a lift | |||
There was a problem hiding this comment.
This is unrelated but I thought of adding it @jaredcrowe as it is a bit safer. It does cause another render in the lift cycle which is lame - but I think it is safest to do this
alexreardon
force-pushed
the
fixing-nested-draggables-for-touch
branch
from
edb6d1e to
719a7ce
Compare
jaredcrowe
reviewed
Nov 16, 2017
| // browser interactions as possible. | ||
| // event.preventDefault() in an onTouchStart blocks almost | ||
| // every other event including force press | ||
| event.stopPropagation(); |
There was a problem hiding this comment.
yep - it stops the event bubbling up.
it is super important that we do not call prevent default here - but stopPropogation is fine
jaredcrowe
approved these changes
Nov 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #173