Hooks 🎣 #1208
Hooks 🎣 #1208
Conversation
.size-snapshot.json
Outdated
| "gzipped": 32910 | ||
| "bundled": 327193, | ||
| "minified": 117669, | ||
| "gzipped": 33593 |
There was a problem hiding this comment.
This was suprising
There was a problem hiding this comment.
I was expecting moving away from classes would be a drop, but it has gone the other way
.size-snapshot.json
Outdated
| "treeshaked": { | ||
| "rollup": { | ||
| "code": 85891, | ||
| "import_statements": 832 | ||
| "code": 30284, |
There was a problem hiding this comment.
This is quite a nice drop. @TrySound I am not sure what this property is referring too. Can you please explain this property?
There was a problem hiding this comment.
This is the code in user bundle when you import nothing. Useful for ui libs like material ui. Does not mean a lot for this lib though.
src/view/droppable/droppable.jsx
Outdated
| </AnimateInOut> | ||
| ); | ||
|
|
||
| // const placeholder: Node | null = instruction ? ( |
| // It is okay for these properties to be applied on elements that are not flex children | ||
| flexShrink: '0', | ||
| flexGrow: '0', | ||
| // Just a little performance optimisation: avoiding the browser needing |
There was a problem hiding this comment.
TODO: move to style marshal?
| return; | ||
| } | ||
|
|
||
| checkReactVersion(peerDependencies.react, React.version); |
There was a problem hiding this comment.
I would wrap this check with condition. It looks like early returns does not eliminated well with webpack uglify pair.
#871