compose with redux dev tools in development mode only #1085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexreardon
approved these changes
Jan 30, 2019
src/state/create-store.js
Outdated
| const composeEnhancers = | ||
| typeof window !== 'undefined' && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ | ||
| isDevelopment && |
There was a problem hiding this comment.
process.env.NODE_ENV !== 'production'
Sometimes there are other env strings used that are not development such as 'test'
src/state/create-store.js
Outdated
| @@ -20,8 +20,12 @@ import type { Store } from './store-types'; | |||
| // We are checking if window is available before using it. | |||
| // This is needed for universal apps that render the component server side. | |||
| // Details: https://github.com/zalmoxisus/redux-devtools-extension#12-advanced-store-setup | |||
| const isDevelopment: boolean = process.env.NODE_ENV === 'development'; | |||
There was a problem hiding this comment.
Suggested change
| const isDevelopment: boolean = process.env.NODE_ENV === 'development'; |
src/state/create-store.js
Outdated
| const composeEnhancers = | ||
| typeof window !== 'undefined' && window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ | ||
| isDevelopment && |
There was a problem hiding this comment.
Suggested change
| isDevelopment && | |
| process.env.NODE_ENV !== 'production' && |
|
Thanks!!! |
|
This will go out in the next release (some time in the next two weeks 🤞 ) |
|
Thanks @alexreardon for taking a look, great work on this package btw 🥇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.