Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more robust typeof element checks #1067

Merged
merged 8 commits into from
Jan 23, 2019
Merged

more robust typeof element checks #1067

merged 8 commits into from
Jan 23, 2019

Conversation

alexreardon
Copy link
Collaborator

@alexreardon alexreardon commented Jan 23, 2019 •
edited
Loading

Closes #797 #796

@alexreardon alexreardon changed the title duck typing typeof checks more robust typeof element checks Jan 23, 2019
@alexreardon
Copy link
Collaborator Author

alexreardon commented Jan 23, 2019 •
edited
Loading

I figured out a way to do this without relying on duck typing 👍👍👍

Maintaining the same type safety while allowing iframes

wow-jake

@alexreardon
Copy link
Collaborator Author

cc @jdillick @vladkucherov @SenyaMur

@SenyaMur
Copy link

Thank you! When you will publish this solution?

@alexreardon
Copy link
Collaborator Author

Soon 🤞

@alexreardon alexreardon merged commit baf7873 into master Jan 23, 2019
@alexreardon alexreardon deleted the duck-typing branch January 23, 2019 22:39
@alexreardon alexreardon mentioned this pull request Mar 12, 2019
Closed
@Tinyik Tinyik mentioned this pull request Apr 2, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexreardon @SenyaMur