fixing keyboard dropping when inside of a nested list #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cause the parent to lift
alexreardon
force-pushed
the
fixing-nested-keyboard-lifting
branch
from
89244c5
to
b7ad5e0
Compare
alexreardon
commented
Sep 19, 2017
| @@ -1005,6 +1005,18 @@ describe('drag handle', () => { | |||
| onKeyLift: 0, | |||
| })).toBe(true); | |||
| }); | |||
|
|
|||
| it('should not lift if disabled', () => { | |||
There was a problem hiding this comment.
lifting restriction where spacebar could not be used during a mouse drag - now that we listen to the window scroll we no longer need this! 🎉
jaredcrowe
approved these changes
Sep 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.