Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to react-redux v6, move to React.createContext and React 16.6 #984

Closed
alexreardon opened this issue Dec 5, 2018 · 4 comments
Closed

Comments

@alexreardon
Copy link
Collaborator

alexreardon commented Dec 5, 2018

react-redux v6 just came out, so it is time to move to React.createContext

I think it makes sense to move to React 16.6 in order to use Class.contextType

Because this will change the peer dep version this will be a breaking change

@alexreardon
Copy link
Collaborator Author

The only sad thing about this is react-redux v6 is a little slower than v5. I will need to see if it has a material impact on things. Otherwise we might need to role something custom

@JamieDixon
Copy link

JamieDixon commented Dec 6, 2018

Thank you for react beautiful DND. It's saved me soo much time.

I'm wondering if it's possible to separate some of these items into their own PRs/Releases?

I'm using a few packages that depend on an older version of react-redux and it's going to take some time for those packages to land new releases (meaning I can't bump to react-redux v6 just yet). In the meantime I would love to see React.createContext implemented in this package to help reduce the number of errors I get with StrictMode.

What do you think? Is this feasible? 🙂

Thank you.

@mDibyo
Copy link

mDibyo commented Mar 14, 2019

Hey @JamieDixon, It should be completely fine to have multiple versions of react-redux in your codebase. Are you worried about the increase in bundle size?

@alexreardon
Copy link
Collaborator Author

Done in 11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants