Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with strict peerDependency #84

Closed
pofigizm opened this issue Sep 8, 2017 · 3 comments
Closed

Problem with strict peerDependency #84

pofigizm opened this issue Sep 8, 2017 · 3 comments

Comments

@pofigizm
Copy link
Contributor

pofigizm commented Sep 8, 2017

Firstly, thanks for this component, it's great.

Why this component has strict peerDependency react 15.6.1?
Have you real causes for it?
Could it be changed to somthing like >=15.4.0?
We cannot use your component if we have other react version.
We very disappointed about it.

Thanks.

@alexreardon
Copy link
Collaborator

We can totally make it a fuzzy version. I was hoping to change it but forgot. Any reason you want it to go back to 15.4? 15.5 seems like a better way to go https://github.com/facebook/react/blob/master/CHANGELOG.md

@pofigizm
Copy link
Contributor Author

pofigizm commented Sep 8, 2017

We have big project and we use version 15.4.
I didn't find any changes in react since 15.4 which can affect your component.
You increase users if you have milder restrictions.

All tests passed with react 14.4, I have checked.
It can't affect existed users because they have newer version of react.

Could I made PR with this? ;)

@alexreardon
Copy link
Collaborator

alexreardon commented Sep 8, 2017

If all the tests are passing 15.4 then a PR sounds fine. Can you please also check the supported browsers that it is all good?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants