Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object doesn't support property or method 'find' in IE11 #724

Closed
wzc19920413 opened this issue Aug 22, 2018 · 9 comments · Fixed by #783
Closed

Object doesn't support property or method 'find' in IE11 #724

wzc19920413 opened this issue Aug 22, 2018 · 9 comments · Fixed by #783

Comments

@wzc19920413
Copy link

Bug or feature request?

Bug

Expected behavior

To be able to drag and drop on IE11

Actual behavior

App can not be opened and cause error:

SCRIPT438: Object doesn't support property or method 'find'

Steps to reproduce

I think this is related to #320

The console error points to the file supported-page-visibility-event-name.js

Not sure whether there are other files that would cause the error

What version of React are you using?

16.2.0

What version of react-beautiful-dnd are you running?

9.0.0

What browser are you using?

IE11

Demo

@alexreardon
Copy link
Collaborator

@alexreardon
Copy link
Collaborator

I don't think we will stop using .find, but we should be clearer about what polyfills are required for IE11.

@wuweiweiwu
Copy link
Contributor

Can I pick this up? :)

@alexreardon
Copy link
Collaborator

Sure @wuweiweiwu. At this stage we would be after a guide that states that we require .find to be polyfilled for ie11

alexreardon pushed a commit that referenced this issue Sep 6, 2018
closes: #724 

Add note to users that `Array.prototype.find` needs to be polyfilled
@tgormtx
Copy link

tgormtx commented Oct 22, 2018

I've added polyfills to my app and it doesn't solve the problem. Why is filter, which is support, not being used?

@alexreardon
Copy link
Collaborator

@tgormtx this has now been resolved in version 10 which should be shipping soon. We will no longer require any poly filling for ie 11

#838

@alexreardon
Copy link
Collaborator

Closed by #838. See version 10 release notes

@wuweiweiwu
Copy link
Contributor

Should the README be updated?

@alexreardon
Copy link
Collaborator

alexreardon commented Nov 18, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants