-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove temporary iOS 11.3 fix #417
Labels
Comments
The bug has been fixed in safari and should be released in iOS 12. Once that soaks for a few weeks we will remove the work around from our code |
See the webkit bug for more info |
But there is a followup bug that needs to be fixed: https://bugs.webkit.org/show_bug.cgi?id=185656 |
I have included a smaller fix in 11.0.5 and 12.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As a part of #413 and #416 we introduced an always active
touchmove
listener to get around a webkit bug. Once the bug is fixed in webkit I am keen to remove the hack.Also, the hack was only to get touch dragging working again. Currently any other calls to
event.preventDefault()
will not do anything in webkit (egmousemove
is currently not being prevented during a mouse drag). This goes against our how we use DOM events guide.When webkit is fixed we will be able to:
The text was updated successfully, but these errors were encountered: