Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary iOS 11.3 fix #417

Closed
alexreardon opened this issue Apr 3, 2018 · 5 comments
Closed

Remove temporary iOS 11.3 fix #417

alexreardon opened this issue Apr 3, 2018 · 5 comments

Comments

@alexreardon
Copy link
Collaborator

As a part of #413 and #416 we introduced an always active touchmove listener to get around a webkit bug. Once the bug is fixed in webkit I am keen to remove the hack.

Also, the hack was only to get touch dragging working again. Currently any other calls to event.preventDefault() will not do anything in webkit (eg mousemove is currently not being prevented during a mouse drag). This goes against our how we use DOM events guide.

When webkit is fixed we will be able to:

  1. remove the workaround
  2. have consistent event prevention on webkit browsers
@alexreardon
Copy link
Collaborator Author

The bug has been fixed in safari and should be released in iOS 12. Once that soaks for a few weeks we will remove the work around from our code

@alexreardon
Copy link
Collaborator Author

See the webkit bug for more info

@acampagna
Copy link

But there is a followup bug that needs to be fixed: https://bugs.webkit.org/show_bug.cgi?id=185656

@alexreardon
Copy link
Collaborator Author

I have included a smaller fix in 11.0.5 and 12.x

@alexreardon
Copy link
Collaborator Author

#1407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants