Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong scroll position after drop in scroll container #290

Closed
komlew opened this issue Jan 23, 2018 · 2 comments
Closed

Wrong scroll position after drop in scroll container #290

komlew opened this issue Jan 23, 2018 · 2 comments

Comments

@komlew
Copy link

komlew commented Jan 23, 2018

Bug or feature request?

Bug

Steps to reproduce

  1. Open storybook frame with "Droppable is a scroll container" (https://react-beautiful-dnd.netlify.com/?selectedKind=single%20vertical%20list&selectedStory=Droppable%20is%20a%20scroll%20container&full=0&down=1&left=1&panelRight=0&downPanel=storybook%2Factions%2Factions-panel).
  2. Grab one of the elements at the top of the list.
  3. Scroll the container down until you reach the bottom.
  4. Drop the element at the last position.

Expected behavior

The draggable block is moved to the last position, scroll position of the container is at its end, so you can see the element you've just dropped (it's at the bottom of the container).

Actual behavior

The draggable block is moved to the last position, the container is scrolled until the new element, so you can't see the element you've just dropped (it's bellow the container scroll position).

Browser version

Google Chrome, Version 63.0.3239.132 (Official Build) (64-bit)

Demo

Added animated gif (8mb) below...

scroll_container

@alexreardon
Copy link
Collaborator

Spot on @komlew. We will track this in #291.

Thanks!

@komlew
Copy link
Author

komlew commented Jan 24, 2018

Thanks, @alexreardon

That's after reading your great article https://medium.com/@alexandereardon/dragging-react-performance-forward-688b30d40a33

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants