Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invariant failed: Announcement node already mounted #1584

Closed
Mangatt opened this issue Nov 6, 2019 · 6 comments · Fixed by #1585
Closed

Invariant failed: Announcement node already mounted #1584

Mangatt opened this issue Nov 6, 2019 · 6 comments · Fixed by #1585

Comments

@Mangatt
Copy link

Mangatt commented Nov 6, 2019

Expected behavior

There should be no such warnings in the console.

Actual behavior

After HMR update, react-beautiful-dnd throws error that is catched by it's error boundary. Error is throwed on every update, no matter if updated Component is inside or outside DragDropContext.

What version of React are you using?

16.11.0

What version of react-beautiful-dnd are you running?

12.0.0

What browser are you using?

Google Chrome 78.0.3904.8

@alexreardon
Copy link
Collaborator

Hi there!

Thanks for raising this issue. Can you please create a standalone example on codesandbox.io using our boilerplate: https://codesandbox.io/s/k260nyxq9v

Without a standalone example, we will not be able to action this one

Cheers!

@Mangatt
Copy link
Author

Mangatt commented Nov 6, 2019

@alexreardon How can I emulate HMR problem on codesandbox.io?

@alexreardon
Copy link
Collaborator

Sorry, what does HMR stand for?

@alexreardon
Copy link
Collaborator

oh, hot module reload?

@alexreardon
Copy link
Collaborator

I can see why this could occur

@Mangatt
Copy link
Author

Mangatt commented Nov 6, 2019

Yes, hot module reloading.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants