Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution files? #142

Closed
Frozenlock opened this issue Oct 19, 2017 · 12 comments
Closed

Distribution files? #142

Frozenlock opened this issue Oct 19, 2017 · 12 comments

Comments

@Frozenlock
Copy link

In the Clojurescript world we often package JS libraries for ease of use.

When doing so, it's encouraged to use the official distribution files (dist/). This helps us upgrade packages and keep them in sync with the JS libraries.

I was ready to package and use this project but couldn't find those files 😢

Would it be possible to add this into react-beautiful-dnd?

@jaredcrowe
Copy link
Contributor

Hey @Frozenlock thanks for raising this. We investigated this in the past (#81) and it's something we'd be happy to add at some point. Right now we are focused on priorities from our immediate roadmap so we won't be able to address this right away, but we'd be open to PRs from anyone from the community who would like to work on this :)

@MediumRareByte
Copy link
Contributor

I'd like to contribute to solve this issue. However, I am not entirely sure how to approach it. At first I thought to remove ./lib from git ignore. But after brief research, looks like Clojurescript expect a bundle. Would a rollup/webpack bundle be a viable option?

@alexreardon
Copy link
Collaborator

Great to hear @vinifala!! I am not familiar with the particulars of what is needed for Clojurescript. The ideal would be if we also built a single bundle for distribution. Eg in /dist

@alexreardon
Copy link
Collaborator

Please take a look at the prior work here: #81

@alexreardon
Copy link
Collaborator

Closed by #186

@alexreardon
Copy link
Collaborator

@Frozenlock let me know how you go getting it onto https://cljsjs.github.io/ . I can add a link from this repo when it is up. Cheers

@alexreardon
Copy link
Collaborator

@Frozenlock any update on this?

@Frozenlock
Copy link
Author

@alexreardon Sorry for the delay, I'll try to do it in the next few days.

@alexreardon
Copy link
Collaborator

All good!

@Frozenlock
Copy link
Author

Done!
React-beautiful-dnd is now available as a cljsjs package.

Thank you so much for the distribution files!

@alexreardon
Copy link
Collaborator

So great @Frozenlock !!! I'll add a link to the readme!

@kennetpostigo
Copy link

Are there any examples of usage of the library in cljs? (would be super helpful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants