Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning between lists with the keyboard does not respect container clipping #136

Closed
jaredcrowe opened this issue Oct 9, 2017 · 3 comments · Fixed by #137
Closed
Assignees
Labels

Comments

@jaredcrowe
Copy link
Contributor

jaredcrowe commented Oct 9, 2017

Bug or feature request?

Bug

Expected behaviour

When moving between lists with the keyboard, a droppable's dimension will be clipped if it's within in a scroll container.

Actual behaviour

A droppable's dimensions do not appear to be clipped by a scrollable parent.

Steps to reproduce

On the multiple vertical lists stress test story:

  1. Add a lot of items to the epsilon board
  2. Scroll all the way to the bottom of epsilon's container
  3. Try to move an item into the delta board with the keyboard

Browser version

Chrome Version 61.0.3163.100 (Official Build) (64-bit)

Demo

https://drive.google.com/file/d/0B9It2FnzHQ-vSmFvVGZOVW5OTE0/view

@jaredcrowe jaredcrowe self-assigned this Oct 9, 2017
@jaredcrowe
Copy link
Contributor Author

Hoping this will be an easy fix once #132 gets in.

@alexreardon
Copy link
Collaborator

Was this created by the last clipping change?

@jaredcrowe
Copy link
Contributor Author

Yeah I expect it probably would have been :( This issue only pops up when you've got long droppables inside scroll containers sitting on the same main axis - I'll add some tests to make sure we cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants