Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incompatible with react-redux@^6.0.0 or @^7.0.0 #1291

Closed
ghost opened this issue May 4, 2019 · 1 comment
Closed

Incompatible with react-redux@^6.0.0 or @^7.0.0 #1291

ghost opened this issue May 4, 2019 · 1 comment

Comments

@ghost
Copy link

ghost commented May 4, 2019

Describe the bug
Error on import of react-beautiful-dnd together with react-redux@^6.0.0 or react-redux@^7.0.0.

This seems to be stemming from the react-redux "Breaking Changes" point #2 noted here.

Error message
Uncaught Invariant Violation: storeKey has been removed and does not do anything. To use a custom Redux store for specific components, create a custom React context with React.createContext(), and pass the context object to React Redux's Provider and specific components like: <Provider context={MyContext}><ConnectedComponent context={MyContext} /></Provider>. You may also pass a {context : MyContext} option to connect

Please see attached log files:
localhost-1556994978137.log

Screenshots
image

To Reproduce
Steps to reproduce the behavior:

  1. create-react-app
  2. yarn add react
  3. yarn add react-redux
  4. yarn add react-beautiful-dnd
  5. add import { DragDropContext } from 'react-beautiful-dnd'; to App.js
  6. yarn start

Expected behavior
It should work with react-redux@^6.0.0 or react-redux@^7.0.0

react-beautiful-dnd version
[email protected]

react-redux versions tested
I get this same error with any of these versions:
[email protected]
[email protected]
[email protected]
[email protected]

react version
react@^16.8.6

@ghost ghost changed the title Breaking Change with React-Redux@^7.0.0 or @^6.0.0 Incompatible with react-redux@^6.0.0 or @^7.0.0 May 5, 2019
@alexreardon
Copy link
Collaborator

alexreardon commented May 6, 2019

See here: #1056 (comment)

Please do not override react-beautiful-dnd's version of redux. It is an internal dependency. Your bundler would be fine with two versions if it needed it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant