Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix security alert - minimist node package #994

Closed
mvorisek opened this issue Mar 17, 2020 · 2 comments · Fixed by #999 or #1000
Closed

Fix security alert - minimist node package #994

mvorisek opened this issue Mar 17, 2020 · 2 comments · Fixed by #999 or #1000
Assignees

Comments

@mvorisek
Copy link
Member

Alert: https://github.com/atk4/ui/network/alert/package-lock.json/minimist/open

File: https://github.com/atk4/ui/blob/develop/package-lock.json

Introduced by @ibelar - is this file needed at all? It seems like a mistake - e38e0c0 , the commit title says "updated", but in reality it adds this file.

@mvorisek
Copy link
Member Author

The mentioned lock file in the security alert was not fixed - @ibelar, is the fix really a fix to that issue?

And for me that lock file looks like a mistake, it should be probably removed and maybe even added to .gitignore.

It seems like a mistake - e38e0c0 , the commit title says "updated", but in reality it adds this file.

@ibelar
Copy link
Contributor

ibelar commented Mar 18, 2020

@mvorisek -thks. Not sure how package-json.lock file end up in main directory, but should not be there anyhow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants