Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMPROVEMENT] renaming hook addHook method #966

Closed
georgehristov opened this issue Feb 22, 2020 · 3 comments
Closed

[IMPROVEMENT] renaming hook addHook method #966

georgehristov opened this issue Feb 22, 2020 · 3 comments
Assignees
@romaninsh @georgehristov

Comments

@georgehristov
Copy link
Collaborator

I find the hook methods (hook and addHook) a bit confusing for newcomers.

How about renaming the addHook to onHook (keeping BC) to make it more intuitive?
IMHO this would improve the DX.

If agreed with the change you can assign me to that issue.
@georgehristov georgehristov changed the title [IMPROVEMENT] renaming hook adHook method [IMPROVEMENT] renaming hook addHook method Feb 22, 2020
This was referenced Feb 24, 2020
Merged
Merged
Merged
@georgehristov georgehristov reopened this Feb 26, 2020
@georgehristov
Copy link
Collaborator Author

Maybe I am a bit obsessed with semantics but starting to think that onHook should even be simply on
WDYT?

@PhilippGrashoff
Copy link
Collaborator

Dont like it, as "on" does not give any hint what it does. "onHook" states clearly that it has something to do with a hook.
There also is "on" in ATK UI, definitely that could confuse new ATK users.

@georgehristov
Copy link
Collaborator Author

Good, then we can close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romaninsh romaninsh

@georgehristov georgehristov

Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@romaninsh @georgehristov @PhilippGrashoff