Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Improvements to jsReload #75

Closed
2 of 4 tasks
romaninsh opened this issue Mar 18, 2017 · 2 comments
Closed
2 of 4 tasks

Minor Improvements to jsReload #75

romaninsh opened this issue Mar 18, 2017 · 2 comments
Labels
JS
Milestone
1.x - Clean-ups

Comments

@romaninsh
Copy link
Member

romaninsh commented Mar 18, 2017 •
edited
Loading

Some things that need to be improved:

  • jsReloader should not delete current content until new content is loaded. Otherwise content collapses causing screen to scroll up.
  • jsReloader should accept additional parameters new jsReloader($view, ['foo'=>$bar])
  • $bar above should allow jsExpression
  • loader should show up only if loading takes longer than 1 second (over current content).
@romaninsh romaninsh mentioned this issue Mar 22, 2017
Closed
@romaninsh romaninsh added the JS label Mar 29, 2017
@romaninsh romaninsh modified the milestones: 1.1 - More components, 1.1.x - Clean-ups Mar 31, 2017
@romaninsh
Copy link
Member Author

@ibelar - i think most of the items here have been taken care of.

@romaninsh
Copy link
Member Author

see #341

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
1.x - Clean-ups
Development

No branches or pull requests
1 participant
@romaninsh