Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No/bad AJAX response must be handled #1720

Closed
mvorisek opened this issue Dec 27, 2021 · 3 comments
Closed

No/bad AJAX response must be handled #1720

mvorisek opened this issue Dec 27, 2021 · 3 comments
Labels

Comments

@mvorisek
Copy link
Member

When AJAX response is not returned (timeout) or wrong (non-200 status code or wrong JSON/JS syntax)

then the response must be handled in Atk4 frontend JS
and the original AJAX request must be canceled (when not-finished yet, like timeout)

demos/_unit-test/late-output-error.php can be used for Behat testing of wrong AJAX responses

@mvorisek
Copy link
Member Author

mvorisek commented Oct 2, 2022

another example is atk4/login@f475d95 and atk4/login/demos/admin-roles.php demo

when

image

is clicked and then

image

is clicked, faded background is the only thing displayed, no error message, nothing, in network view the following shown:

image

for normal users, it is nearly impossible to tell the problem

@mvorisek
Copy link
Member Author

mvorisek commented Oct 5, 2022

another easy steps to reproduce/modal usecase described in #1883 (comment)

@mvorisek
Copy link
Member Author

mostly fixed by #1925 and #1919

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant