Fix hook trait usage

[mvorisek]

Fix these once atk4/core#133 is merged:

Regex:

(?<!  \$this)(?<!  \$m)->(?:onHook|hook)\s*\(

Code to be fixed:

• data/src/Model.php

  Line 1387 in 42475e2

  return $ret;

  • return is indexed differently

• data/src/Model.php

  Line 1611 in 42475e2

  return $ret;

  • return is indexed differently

• data/src/Model.php

  Line 1649 in 42475e2

  return $ret;

  • return is indexed differently

• data/src/Model.php

  Line 1690 in 42475e2

  return $ret;

  • return is indexed differently

• data/src/Model.php

  Line 2112 in 42475e2

  if (is_object($ret)) {

  • return is indexed differently
  • is this to detect breaked hook or why is there an object check?

[mvorisek]

Please check the questions above and close if no actions are needed.

[romaninsh]

@mvorisek to answer your question - is_object check allow model substitution after loading:

https://github.com/atk4/data/pull/361/files#diff-83e9e6704bdede75a707d11294b67376R1035

[mvorisek]

@mvorisek to answer your question - is_object check allow model substitution after loading:

https://github.com/atk4/data/pull/361/files#diff-83e9e6704bdede75a707d11294b67376R1035

@romaninsh When is it code intended to be reached? This code pattern seems to be used only here. See also my PR atk4/core#187 which solves the hook break detection.

[mvorisek]

checked, probably no action is needed