Skip to content
This repository has been archived by the owner on Aug 18, 2023. It is now read-only.

Properly handle context canceled scenario: don't report as an error #170

Open
atc0005 opened this issue Jan 31, 2022 · 0 comments
Open

Properly handle context canceled scenario: don't report as an error #170

atc0005 opened this issue Jan 31, 2022 · 0 comments
Assignees
@atc0005
Labels
bug Something isn't working logging
Milestone
Future

Comments

@atc0005
Copy link
Owner

atc0005 commented Jan 31, 2022

Output from using Ctrl+c to stop a running instance:

  WARN[2702] bounce is shutting down, please wait ...
 ERROR[2702] gracefulShutdown: could not gracefully shutdown the server: context canceled
  INFO[2702] bounce successfully shutdown

The WARN and INFO messages are fine, but the ERROR is not an error, it is expected. The error code check currently applied by the gracefulShutdown goroutine (or its handling) should should that particular error.
@atc0005 atc0005 added bug Something isn't working logging labels Jan 31, 2022
@atc0005 atc0005 added this to the Next Release milestone Jan 31, 2022
@atc0005 atc0005 self-assigned this Jan 31, 2022
@atc0005 atc0005 modified the milestones: v0.4.18, Future Mar 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@atc0005 atc0005

Labels
bug Something isn't working logging
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@atc0005