Implement a rumble delay pool #253
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakra
force-pushed
the
rumble-delay-pool
branch
from
8d5b073
to
75c125c
Compare
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
kakra
force-pushed
the
rumble-delay-pool
branch
4 times, most recently
from
e8092ed
to
cc660d2
Compare
10 tasks
kakra
force-pushed
the
rumble-delay-pool
branch
10 times, most recently
from
4b67969
to
f2bbb7b
Compare
Signed-off-by: Kai Krakow <[email protected]>
kakra
force-pushed
the
rumble-delay-pool
branch
from
f2bbb7b
to
dd49347
Compare
|
Code Climate has analyzed commit dd49347 and detected 0 issues on this pull request. View more on Code Climate. |
|
This doesn't help stability and only increases complexity and rumble lagging. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Research showed that there are users who only experience the controller crash with longer bursts of rumble. This PR tries to implement a delay pool to work around bursts.
My personal tests show no positive effect, tho.
Affects: #243
Affects: #247
Maybe-related: #198
See-also: https://answers.microsoft.com/en-us/xbox/forum/all/xbox-elite-series-2-disconnecting-from-pc/7e5a964a-16cc-4e83-8dec-aa8c858b875c