Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update release workflow on release branch #956

Merged
merged 3 commits into from
Jul 26, 2023

Conversation

kaushik-rishi
Copy link
Contributor

@kaushik-rishi kaushik-rishi commented Jul 25, 2023


title: "Update the release workflow on the release branch (next-major-spec)"


Related issue(s):
Fixes #938


Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure all these updates will fix the release looking at the error:

[9:11:12 PM] [semantic-release] › ℹ  Start step "analyzeCommits" of plugin "@semantic-release/commit-analyzer"
(node:1734) UnhandledPromiseRejectionWarning: TypeError: config.types.flatMap is not a function
    at getWriterOpts (/home/runner/work/spec/spec/node_modules/conventional-changelog-conventionalcommits/writer-opts.js:76:41)
    at module.exports (/home/runner/work/spec/spec/node_modules/conventional-changelog-conventionalcommits/writer-opts.js:47:22)
(node:1734) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 1)
(node:1734) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

so better if you also npx [email protected] -> npx [email protected]

I checked and the only breaking changes are npm related (not problem here) and requirement for node 18, which is already done in this PR

so we should be good to go

.github/workflows/release.yml Outdated Show resolved Hide resolved
@derberg
Copy link
Member

derberg commented Jul 25, 2023

@kaushik-rishi I cannot make code change suggestion for npx [email protected] so you need to change it on your own

@kaushik-rishi
Copy link
Contributor Author

Updated @derberg .

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg changed the title chore: update release workflow on release branch ci: update release workflow on release branch Jul 26, 2023
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@derberg
Copy link
Member

derberg commented Jul 26, 2023

/rtm

@derberg
Copy link
Member

derberg commented Jul 26, 2023

@smoya in theory all is good now 😄

@asyncapi-bot asyncapi-bot merged commit 6ce7d35 into asyncapi:next-major-spec Jul 26, 2023
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 3.0.0-next-major-spec.13 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants