-
-
Notifications
You must be signed in to change notification settings - Fork 275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update examples to v3 #947
chore: update examples to v3 #947
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
rpc-client was using a parameter with Which both are no longer supported. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR! that our doc contributors are waiting for 🚀
Only small typo.
If we merge this with main, we will loose all the old 2.x.x examples? is this the intention ?
version: '1.0.0' | ||
description: A cut of the Streetlights API to test application header changes supporting #112 | ||
version: 1.0.0 | ||
description: A cut of the Streetlights API to test application header changes supporting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jonaslagoni #112
is missing here, otherwise the meaning is not correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, it's a bug with the converter 🤔
Mind adding a bug issue?
receiveLightMeasurement: | ||
action: receive | ||
channel: | ||
$ref: >- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't knew this notion >-
is it to allow multi-lines in that case why not having #/channels/smartylighting~1streetlights~11~10~1event~1{streetlightId}~1lighting~1measured
in the same line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's part of the converter logic somewhere 🤔
Might be because the string is too long 🧐
It is yes. We can keep a copy of the v2 examples if we want in a sub directory 🤔 |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
I don't think we should do it, basically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rtm |
Thanks folks 😄 |
🎉 This PR is included in version 3.0.0-next-major-spec.13 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This PR updates all examples to v3, as well as introducing a tool that automates the process for the next releases, by utilizing the converter.