Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change schema.uid() method to schema.id() #643

Merged
merged 1 commit into from
Oct 6, 2022
Merged

fix: change schema.uid() method to schema.id() #643

merged 1 commit into from
Oct 6, 2022

Conversation

smoya
Copy link
Member

@smoya smoya commented Oct 6, 2022

Description

This PR renames the schema.uid() method to become schema.id() to be consistent with all the other models (which are using id() as well).

The change in the parser-api can be seen here.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

magicmatatjahu
magicmatatjahu approved these changes Oct 6, 2022
View reviewed changes
Copy link
Member

@magicmatatjahu magicmatatjahu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@smoya
Copy link
Member Author

smoya commented Oct 6, 2022

/rtm

@asyncapi-bot asyncapi-bot merged commit 97c61cb into asyncapi:next-major Oct 6, 2022
@smoya smoya deleted the fix/schemaId branch October 6, 2022 10:12
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 2.0.0-next-major.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu magicmatatjahu approved these changes

@fmvilas fmvilas Awaiting requested review from fmvilas fmvilas is a code owner

@jonaslagoni jonaslagoni Awaiting requested review from jonaslagoni jonaslagoni is a code owner

@derberg derberg Awaiting requested review from derberg derberg is a code owner

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees
No one assigned
Labels
ready-to-merge released on @next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smoya @asyncapi-bot @magicmatatjahu