-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update for Intellij 2022.3.1 #11
Conversation
update Java to 17 update Kotlin to 1.7.22 update gradle plugin 'org.jetbrains.intellij' to 1.11.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
HI @nexoscp thanks for jumping in to help. Before approving this PR, please first approve (in this order): ...at which point I think we'll need to figure out some inconsistencies with dependency versions |
build.gradle.kts
Outdated
java | ||
kotlin("jvm") version "1.6.20" | ||
kotlin("jvm") version "1.7.22" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see Kotlin 1.7.22 here: https://kotlinlang.org/docs/releases.html#release-details
Am I missing something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Gradle Intellij Plugin depends on Kotlin 1.7.22: https://github.com/JetBrains/gradle-intellij-plugin/blob/v1.11.0/build.gradle.kts#L12
Kotlin 1.7.22 can be found here: https://github.com/JetBrains/kotlin/releases/tag/v1.7.22
build.gradle.kts
Outdated
} | ||
|
||
group "com.asyncapi.plugin.idea" | ||
version = "1.7.1+idea2021" | ||
version = "1.7.1+idea2022" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might I suggest this be 1.8.1+idea2022
?
If so, this PR should be against that release branch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isn't this the 1.8.0 release branch?
@@ -54,19 +52,21 @@ tasks.getByName<org.jetbrains.intellij.tasks.RunPluginVerifierTask>("runPluginVe | |||
"2022.2", | |||
"2022.2.1", | |||
"2022.2.2", | |||
"2022.2.3" | |||
"2022.2.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add 2022.2.4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
@nexoscp please see comments above. Also, I would suggest providing logs for |
Happy to provide these logs. But propose to have a ci build do this. |
@philCryoport i'm not part of the AsyncAPI organisation |
Thank you -- I find it useful to include the build logs in a comment to prove that one actually ran it |
Done |
Hi @nexoscp ! Two things:
|
There is a new Version of the Gradle Plugin: 1.12.0 with support for Kotlin 1.8.0. Should we update these dependencies? |
Hi @nexoscp As we're still waiting for someone to approve the PRs for 2022.2.4 and 2022.3...I don't see why not... |
and Kotlin to 1.8.0
Huzzah! |
update Java to 17
update Kotlin to 1.8.0
update gradle plugin 'org.jetbrains.intellij' to 1.12.0
Report gradle buildPlugin
See: https://jb.gg/intellij-platform-versions
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-jdk8/1.8.0/kotlin-stdlib-jdk8-1.8.0.pom, took 101 ms (1,58 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/annotations/24.0.0/annotations-24.0.0.pom, took 102 ms (1,32 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-jdk7/1.8.0/kotlin-stdlib-jdk7-1.8.0.pom, took 18 ms (1,39 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/1.8.0/kotlin-stdlib-1.8.0.pom, took 21 ms (1,55 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-common/1.8.0/kotlin-stdlib-common-1.8.0.pom, took 13 ms (1,16 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/annotations/24.0.0/annotations-24.0.0.jar, took 22 ms (30,54 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib-common/1.8.0/kotlin-stdlib-common-1.8.0.jar, took 133 ms (217,44 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-stdlib/1.8.0/kotlin-stdlib-1.8.0.jar, took 562 ms (1,64 MB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-script-runtime/1.8.0/kotlin-script-runtime-1.8.0.pom, took 53 ms (1,15 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-script-runtime/1.8.0/kotlin-script-runtime-1.8.0.jar, took 34 ms (42,83 kB)
Download https://repo.maven.apache.org/maven2/org/jetbrains/kotlin/kotlin-reflect/1.6.10/kotlin-reflect-1.6.10.jar, took 1 s 170 ms (3,04 MB)
BUILD SUCCESSFUL in 39s
14 actionable tasks: 13 executed, 1 up-to-date
22:42:22: Execution finished 'buildPlugin'.
Report gradle runPluginVerifier
See: https://jb.gg/intellij-platform-versions
2023-01-23T09:58:32 [main] INFO verification - Finished 1 of 24 verifications (in 0,8 s): IC-212.5457.46 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:32 [main] INFO verification - Finished 2 of 24 verifications (in 0,8 s): IC-212.4746.92 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:32 [main] INFO verification - Finished 3 of 24 verifications (in 0,8 s): IC-212.5080.55 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:33 [main] INFO verification - Finished 4 of 24 verifications (in 1,0 s): IC-212.5284.40 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 5 of 24 verifications (in 1,2 s): IC-213.6777.52 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 6 of 24 verifications (in 1,0 s): IC-213.7172.25 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 7 of 24 verifications (in 2,2 s): IC-211.7442.40 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 8 of 24 verifications (in 1,5 s): IC-213.5744.223 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 9 of 24 verifications (in 1,5 s): IC-213.6461.79 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 10 of 24 verifications (in 2,3 s): IC-211.6693.111 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 11 of 24 verifications (in 2,4 s): IC-211.7628.21 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:34 [main] INFO verification - Finished 12 of 24 verifications (in 2,8 s): IC-211.7142.45 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:35 [main] INFO verification - Finished 13 of 24 verifications (in 1,0 s): IC-221.5080.210 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:35 [main] INFO verification - Finished 14 of 24 verifications (in 1,3 s): IC-221.5787.30 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:35 [main] INFO verification - Finished 15 of 24 verifications (in 1,5 s): IC-221.5591.52 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:35 [main] INFO verification - Finished 16 of 24 verifications (in 1,4 s): IC-221.6008.13 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:35 [main] INFO verification - Finished 17 of 24 verifications (in 1,6 s): IC-222.3345.118 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 18 of 24 verifications (in 1,7 s): IC-221.5921.22 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 19 of 24 verifications (in 1,2 s): IC-222.4167.29 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 20 of 24 verifications (in 1,7 s): IC-222.3739.54 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 21 of 24 verifications (in 1,0 s): IC-222.4345.14 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 22 of 24 verifications (in 0,9 s): IC-222.4459.24 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 23 of 24 verifications (in 0,9 s): IC-223.7571.182 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
2023-01-23T09:58:36 [main] INFO verification - Finished 24 of 24 verifications (in 0,9 s): IC-223.8214.52 against com.asyncapi.plugin.idea:1.8.1+idea2022: Compatible
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-212.5457.46: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-212.4746.92: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-212.5080.55: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-212.5284.40: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-213.6777.52: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-213.7172.25: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-211.7442.40: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-213.5744.223: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-213.6461.79: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-211.6693.111: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-211.7628.21: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-211.7142.45: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-221.5080.210: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-221.5787.30: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-221.5591.52: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-221.6008.13: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-222.3345.118: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-221.5921.22: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-222.4167.29: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-222.3739.54: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-222.4345.14: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-222.4459.24: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-223.7571.182: Compatible
Plugin can be loaded/unloaded without IDE restart
Plugin com.asyncapi.plugin.idea:1.8.1+idea2022 against IC-223.8214.52: Compatible
Plugin can be loaded/unloaded without IDE restart
2023-01-23T09:58:36 [main] INFO verification - Total time spent downloading plugins and their dependencies: 0 ms
2023-01-23T09:58:36 [main] INFO verification - Total amount of plugins and dependencies downloaded: 0 B
2023-01-23T09:58:36 [main] INFO verification - Total amount of space used for plugins and dependencies: 0 B
BUILD SUCCESSFUL in 2m 24s
17 actionable tasks: 11 executed, 6 up-to-date
09:58:37: Execution finished 'runPluginVerifier'.