🦋 Changeset detected

Latest commit: de545b5

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@neoandmatrix please add screenshots for the validation thanks

@neoandmatrix please add screenshots for the validation thanks

My apologies forgot to add it beforehand.

Here is the result after changes. Even without extension of file given studio opens it correctly.

@neoandmatrix please add screenshots for the validation thanks

My apologies forgot to add it beforehand.

Here is the result after changes. Even without extension of file given studio opens it correctly.

@neoandmatrix can you add some test cases as well ?

@neoandmatrix please add screenshots for the validation thanks

My apologies forgot to add it beforehand.

Here is the result after changes. Even without extension of file given studio opens it correctly.

@neoandmatrix can you add some test cases as well ?

Sure will do.

@AayushSaini101 I tried to add test for above changes but the problem that i am facing is that the changes in this PR allow opening of studio which if i do through tests open the studio which opens fine but the tests don't continue further and get stuck.
Also previous tests start to fail and i believe this test won't be possible to be run in a CI/CD environment as studio won't open in that.
Looking at the already present tests they also don't include tests related to opening of studio.

Any guidance on to where should i look for this or if doing something wrong, will be helpful.

Thanks.

@AayushSaini101 I tried to add test for above changes but the problem that i am facing is that the changes in this PR allow opening of studio which if i do through tests open the studio which opens fine but the tests don't continue further and get stuck. Also previous tests start to fail and i believe this test won't be possible to be run in a CI/CD environment as studio won't open in that. Looking at the already present tests they also don't include tests related to opening of studio.

Any guidance on to where should i look for this or if doing something wrong, will be helpful.

Thanks.

@Souvikns @Shurtu-gal is it possible to test these changes somehow, we don't have any test cases for studio before also ?

Only very specific things can be tested such as file being changed should send websocket events. So these things can be verified. Rest I don't believe can be tested.

No error condition can be checked though.

If we really need to test then would need to look at puppeteer or sth else.

Only very specific things can be tested such as file being changed should send websocket events. So these things can be verified. Rest I don't believe can be tested.

No error condition can be checked though.

If we really need to test then would need to look at puppeteer or sth else.

make sense, we add this as well in GSOC project then would need to look at puppeteer or sth else. thanks

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Only very specific things can be tested such as file being changed should send websocket events. So these things can be verified. Rest I don't believe can be tested.

No error condition can be checked though.

If we really need to test then would need to look at puppeteer or sth else.

make sense, we add this as well in GSOC project then would need to look at puppeteer or sth else. thanks

Sure will do some research on how to achieve the same.

Thanks for guidance.

/rtm