-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SNS section not compatible with AsyncAPI 3.0.0 #255
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
@dpwdec @iancooper please take a look |
SQS README has the same issue. |
@jturek-olx @derberg Thanks for pinging me. I'll talk to @dpwdec |
@jturek-olx @derberg I'll draft a new version that uses AsyncAPI V3. However, as we know that V2 is stilled being used widely I think we should keep the V2 bindings available on master. So should we disambiguate them in same way the main project does with a |
I've raised a PR for SNS: https://github.com/asyncapi/bindings/pull/260/files |
I have merged the PR. @jturek-olx @derberg if you still have concerns please comment here and we can look at a fix |
SNS README is not compatible with AsyncAPI 3.0.0
E.g. the section mentions
subscribe
which is not supported anymorehttps://github.com/asyncapi/bindings/blob/master/sns/README.md
https://www.asyncapi.com/blog/release-notes-3.0.0
The text was updated successfully, but these errors were encountered: