Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNS section not compatible with AsyncAPI 3.0.0 #255

Open
mateusz-wlosek-ppro opened this issue Jul 15, 2024 · 7 comments
Open

SNS section not compatible with AsyncAPI 3.0.0 #255

mateusz-wlosek-ppro opened this issue Jul 15, 2024 · 7 comments

Comments

@mateusz-wlosek-ppro
Copy link

SNS README is not compatible with AsyncAPI 3.0.0
E.g. the section mentions subscribe which is not supported anymore

https://github.com/asyncapi/bindings/blob/master/sns/README.md
https://www.asyncapi.com/blog/release-notes-3.0.0

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@derberg
Copy link
Member

derberg commented Aug 20, 2024

@dpwdec @iancooper please take a look

@jturek-olx
Copy link

SQS README has the same issue.
Any news on that?

@iancooper
Copy link
Collaborator

@jturek-olx @derberg Thanks for pinging me. I'll talk to @dpwdec

@dpwdec
Copy link
Collaborator

dpwdec commented Aug 30, 2024

@jturek-olx @derberg I'll draft a new version that uses AsyncAPI V3. However, as we know that V2 is stilled being used widely I think we should keep the V2 bindings available on master. So should we disambiguate them in same way the main project does with a 2.x.x folder and a 3.0.0 folder?

@dpwdec
Copy link
Collaborator

dpwdec commented Aug 30, 2024

I've raised a PR for SNS: https://github.com/asyncapi/bindings/pull/260/files

@iancooper
Copy link
Collaborator

I have merged the PR. @jturek-olx @derberg if you still have concerns please comment here and we can look at a fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants