WIP: Fee rewards!!! #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstonematt
commented
Oct 9, 2024
| @@ -47,7 +47,7 @@ var ( | |||
| identityVotes = map[string]string{"aaa": "AAA", "bbb": "BBB", "ccc": "CCC"} | |||
| nv = len(identities) | |||
| staticEpochInfo = rpc.EpochInfo{ | |||
| AbsoluteSlot: 166598, | |||
| AbsoluteSlot: 166599, | |||
There was a problem hiding this comment.
no idea why this was changed, but doesn't matter i guess
SEJeff
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main thing done here is adding fee reward tracking. This is done by calling
getBlockfor the slots which we produced and getting the fee reward.Additionally, I also added explicit use of commitment levels for
rpc.Clientmethods.The error handling in this is suboptimal, but improved in an upcoming PR (#40).