Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create forks the are disjoint with requires-python #5818

Closed
konstin opened this issue Aug 6, 2024 · 2 comments
Closed

Don't create forks the are disjoint with requires-python #5818

konstin opened this issue Aug 6, 2024 · 2 comments
Assignees
Labels
performance Potential performance improvement preview Experimental behavior resolver Related to the package resolver

Comments

@konstin
Copy link
Member

konstin commented Aug 6, 2024

Usually, we only consider the lower bound of requires-python in the resolver. For when forking, it doesn't make sense to consider forks above the upper bound, e.g. with ==3.11.*, a fork python_version >= '3.13' doesn't make sense.

pyproject.toml:

[project]
name = "warehouse"
version = "1.0.0"
requires-python = "==3.11.*"
dependencies = [
  "pydantic",
]

[build-system]
requires = ["hatchling"]
build-backend = "hatchling.build"

Head of uv.lock:

version = 1
requires-python = ">=3.11, <3.12"
environment-markers = [
    "python_version < '3.13'",
    "python_version >= '3.13'",
]
@konstin konstin added resolver Related to the package resolver preview Experimental behavior labels Aug 6, 2024
@konstin konstin added the performance Potential performance improvement label Aug 9, 2024
@charliermarsh charliermarsh self-assigned this Aug 9, 2024
@charliermarsh
Copy link
Member

We now do this for Python versions that are below the lower bound, at least.

@charliermarsh
Copy link
Member

Going to close this and create a separate issue around sometimes respecting upper-bound.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance Potential performance improvement preview Experimental behavior resolver Related to the package resolver
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants