Allow is and is not for direct type comparisons
#7905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charliermarsh
commented
Oct 11, 2023
| { | ||
| if !matches!(op, CmpOp::Is | CmpOp::IsNot | CmpOp::Eq | CmpOp::NotEq) { | ||
| continue; | ||
| if is_type(left, checker.semantic()) || is_type(right, checker.semantic()) { |
There was a problem hiding this comment.
Unlike pycodestyle, our rule is symmetric... so, e.g., we flag both type(x) == int and int == type(x).
There was a problem hiding this comment.
is is commutative, but == isn't in Python:
[ins] In [14]: (a == b) == (b == a)
Out[14]: False
[ins] In [15]: (a is b) == (b is a)
Out[15]: True
But I don't think that matters for this linter rule. :)
PR Check ResultsEcosystemℹ️ ecosystem check detected changes. (+3, -1, 0 error(s)) rotki (+3, -1)
- [*] 11 fixable with the `--fix` option (225 hidden fixes can be enabled with the `--unsafe-fixes` option). + [*] 13 fixable with the `--fix` option (225 hidden fixes can be enabled with the `--unsafe-fixes` option). + rotkehlchen/tests/api/test_settings.py:146:81: RUF100 [*] Unused `noqa` directive (unused: `E721`) + rotkehlchen/tests/api/test_settings.py:150:80: RUF100 [*] Unused `noqa` directive (unused: `E721`)
|
dhruvmanila
approved these changes
Oct 11, 2023
Comment on lines
-22
to
28
| /// if type(obj) is type(1): | ||
| /// if type(obj) == type(1): | ||
| /// pass |
There was a problem hiding this comment.
I think that the "Use instead" section needs to contain the following:
if type(obj) is type(1):
pass
Comment on lines
91
to
102
| Expr::Attribute(ast::ExprAttribute { value, .. }) => { | ||
| // Ex) `type(obj) is types.NoneType` | ||
| if checker | ||
| .semantic() | ||
| .resolve_call_path(value.as_ref()) | ||
| .is_some_and(|call_path| matches!(call_path.as_slice(), ["types", ..])) | ||
| { | ||
| checker | ||
| .diagnostics | ||
| .push(Diagnostic::new(TypeComparison, compare.range())); | ||
| } | ||
| } |
There was a problem hiding this comment.
This isn't present in the refactored code, is that an expected behavior?
The following doesn't get violated then:
if type(foo) == types.LambdaType:
...There was a problem hiding this comment.
Yeah, they removed this from pycodestyle with the understanding that a user-defined types would be a lot more common than accessing the standard library's types. I'm torn on it but figured it's fine to follow suit.
|
This may need to go out under preview \cc @zanieb |
Closed
|
@zanieb - What do you think of this? |
|
I agree preview makes sense for this change. Perhaps we should clarify in the versioning policy that we will confine changes in the scope of rules to minor releases. |
charliermarsh
force-pushed
the
charlie/E721
branch
4 times, most recently
from
7fa0918 to
dfcb2f7
Compare
charliermarsh
force-pushed
the
charlie/E721
branch
from
dfcb2f7 to
3ec2ee0
Compare
dhruvmanila
pushed a commit
that referenced
this pull request
Jun 25, 2024
…` (`E721`) (#11220) ## Summary Stabilizes `E721` behavior implemented in #7905. The functionality change in `E721` was implemented in #7905, released in [v0.1.2](https://github.com/astral-sh/ruff/releases/tag/v0.1.2). And seems functionally stable since #9676, without an explicit release but would correspond to [v0.2.0](https://github.com/astral-sh/ruff/releases/tag/v0.2.0). So the deprecated functionally should be removable in the next minor release. resolves: #6465
MichaReiser
pushed a commit
that referenced
this pull request
Jun 27, 2024
…` (`E721`) (#11220) ## Summary Stabilizes `E721` behavior implemented in #7905. The functionality change in `E721` was implemented in #7905, released in [v0.1.2](https://github.com/astral-sh/ruff/releases/tag/v0.1.2). And seems functionally stable since #9676, without an explicit release but would correspond to [v0.2.0](https://github.com/astral-sh/ruff/releases/tag/v0.2.0). So the deprecated functionally should be removable in the next minor release. resolves: #6465
MichaReiser
pushed a commit
that referenced
this pull request
Jun 27, 2024
…` (`E721`) (#11220) ## Summary Stabilizes `E721` behavior implemented in #7905. The functionality change in `E721` was implemented in #7905, released in [v0.1.2](https://github.com/astral-sh/ruff/releases/tag/v0.1.2). And seems functionally stable since #9676, without an explicit release but would correspond to [v0.2.0](https://github.com/astral-sh/ruff/releases/tag/v0.2.0). So the deprecated functionally should be removable in the next minor release. resolves: #6465
charliermarsh
added a commit
that referenced
this pull request
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates our E721 implementation and semantics to match the updated
pycodestylelogic, which I think is an improvement. Specifically, we now allowtype(obj) is intfor exact type comparisons, which were previously impossible. So now, we're largely just linting against code liketype(obj) == int.This change is gated to preview mode.
Closes #7904.
Test Plan
Updated the test fixture and ensured parity with latest Flake8.