Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo in if_key_in_dict_del.rs #14920

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Conversation

InSyncWithFoo
Copy link
Contributor

(Accidentally introduced in #14553).

@AlexWaygood AlexWaygood enabled auto-merge (squash) December 11, 2024 15:49
@AlexWaygood AlexWaygood added the internal An internal refactor or improvement label Dec 11, 2024
auto-merge was automatically disabled December 11, 2024 16:23

Head branch was pushed to by a user without write access

Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find

@MichaReiser MichaReiser enabled auto-merge (squash) December 11, 2024 16:27
@MichaReiser MichaReiser merged commit 0c85023 into astral-sh:main Dec 11, 2024
20 checks passed
@InSyncWithFoo InSyncWithFoo deleted the RUF051 branch December 11, 2024 16:28
Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+16 -16 violations, +0 -0 fixes in 6 projects; 49 projects unchanged)

DisnakeDev/disnake (+3 -3 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ disnake/ext/commands/cog.py:177:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- disnake/ext/commands/cog.py:177:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ disnake/ext/commands/cog.py:179:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- disnake/ext/commands/cog.py:179:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ disnake/ext/commands/cog.py:181:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- disnake/ext/commands/cog.py:181:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

RasaHQ/rasa (+2 -2 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ rasa/core/migrate.py:134:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- rasa/core/migrate.py:134:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ rasa/nlu/classifiers/diet_classifier.py:781:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- rasa/nlu/classifiers/diet_classifier.py:781:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

apache/airflow (+4 -4 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ docs/build_docs.py:604:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- docs/build_docs.py:604:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ docs/build_docs.py:606:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- docs/build_docs.py:606:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ providers/src/airflow/providers/google/cloud/operators/dataproc.py:666:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- providers/src/airflow/providers/google/cloud/operators/dataproc.py:666:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ providers/src/airflow/providers/google/cloud/operators/dataproc.py:680:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- providers/src/airflow/providers/google/cloud/operators/dataproc.py:680:21: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

apache/superset (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ superset/dashboards/schemas.py:185:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- superset/dashboards/schemas.py:185:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

zulip/zulip (+5 -5 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview --select ALL

+ corporate/tests/test_stripe.py:662:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- corporate/tests/test_stripe.py:662:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ zerver/lib/markdown/__init__.py:2456:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- zerver/lib/markdown/__init__.py:2456:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ zerver/lib/test_runner.py:103:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- zerver/lib/test_runner.py:103:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ zerver/tornado/event_queue.py:542:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- zerver/tornado/event_queue.py:542:13: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`
+ zerver/tornado/handlers.py:42:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- zerver/tornado/handlers.py:42:9: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

astropy/astropy (+1 -1 violations, +0 -0 fixes)

ruff check --no-cache --exit-zero --ignore RUF9 --output-format concise --preview

+ astropy/modeling/core.py:189:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `del dict[key]`
- astropy/modeling/core.py:189:17: RUF051 [*] Use `pop` instead of `key in dict` followed by `delete dict[key]`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF051 32 16 16 0 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants