Fix fstring formatting removing overlong implicit concatenated string in expression part #14811
+47
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #14778
The formatter incorrectly removed the inner implicitly concatenated string for following single-line f-string:
This happened because I changed the
RemoveSoftlinesBuffer
in #14489 to remove any content wrapped inif_group_breaks
. After all, it emulates an all flat layout. This works fine whenif_group_breaks
is only used to add content if the gorup breaks. It doesn't work if the same content is rendered differently depending on if the group fits usingif_group_breaks
andif_groups_fits
because the enclosinggroup
might still break if the entire content exceeds the line-length limit.This PR fixes this by unwrapping any
if_group_fits
content by removing theif_group_fits
start and end tags.Test Plan
added test