Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake8-pyi] Add "replace with Self" fix (PYI019) #14238

Merged
merged 9 commits into from
Nov 12, 2024
Merged

[flake8-pyi] Add "replace with Self" fix (PYI019) #14238

merged 9 commits into from
Nov 12, 2024

Conversation

InSyncWithFoo
Copy link
Contributor

Summary

Resolves #14183.

Test Plan

cargo nextest run and cargo insta test.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 10, 2024 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser MichaReiser added the fixes Related to suggested fixes for violations label Nov 11, 2024
MichaReiser
MichaReiser reviewed Nov 11, 2024
View reviewed changes
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
MichaReiser
MichaReiser approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@MichaReiser MichaReiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks!

crates/ruff_linter/src/rules/flake8_pyi/rules/custom_type_var_return_type.rs Outdated Show resolved Hide resolved
@MichaReiser MichaReiser enabled auto-merge (squash) November 12, 2024 10:28
@MichaReiser MichaReiser added the preview Related to preview mode features label Nov 12, 2024
@MichaReiser MichaReiser disabled auto-merge November 12, 2024 10:29
@MichaReiser MichaReiser enabled auto-merge (squash) November 12, 2024 11:08
@MichaReiser MichaReiser merged commit 13a1483 into astral-sh:main Nov 12, 2024
16 checks passed
@InSyncWithFoo InSyncWithFoo deleted the PYI019 branch November 12, 2024 12:10
@BrewTestBot BrewTestBot mentioned this pull request Nov 15, 2024
Merged
@MichaReiser MichaReiser mentioned this pull request Nov 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaReiser MichaReiser MichaReiser approved these changes

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request: Unsafe fix for custom-type-var-return-type/PYI019
2 participants
@InSyncWithFoo @MichaReiser