Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tab-size setting #12835

Merged
merged 4 commits into from
Oct 8, 2024
Merged

Remove tab-size setting #12835

merged 4 commits into from
Oct 8, 2024

Conversation

MichaReiser
Copy link
Member

@MichaReiser MichaReiser commented Aug 12, 2024

Summary

The tab-size setting was deprecated in Ruff 0.1.2 and using it is an error since Ruff 0.5 (#12006).

This PR removes the option entirely.

Closes #12041

Test Plan

ruff failed
  Cause: Failed to parse /home/micha/astral/test/pyproject.toml
  Cause: TOML parse error at line 1, column 1
  |
1 | [tool.ruff]
  | ^^^^^^^^^^^
unknown field `tab-size`

@MichaReiser MichaReiser added the configuration Related to settings and configuration label Aug 12, 2024
@MichaReiser MichaReiser force-pushed the remove-tab-size-setting branch 2 times, most recently from b1f98e7 to dbdfac2 Compare August 12, 2024 09:28
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been deprecated for a very long time so I'm okay with removing it, but I also think it would be fine to leave the nice error message there for another minor version. It's not really a maintenance burden 😄

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #12835 will not alter performance

Comparing remove-tab-size-setting (233ce67) with ruff-0.7 (2a615d2)

Summary

✅ 32 untouched benchmarks

Copy link
Contributor

github-actions bot commented Aug 12, 2024

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@MichaReiser
Copy link
Member Author

It's been deprecated for a very long time so I'm okay with removing it, but I also think it would be fine to leave the nice error message there for another minor version. It's not really a maintenance burden 😄

I consider it a maintenance burden because we consider it for removal in every minor but never go through with it. That's why we should either decide to close the tasks and not remove them until 1.0 (or in ten years when the above argument no longer applies) or to go forward with it.

@MichaReiser MichaReiser added this to the v0.7 milestone Aug 12, 2024
@MichaReiser MichaReiser changed the base branch from ruff-0.6 to main August 12, 2024 14:00
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood AlexWaygood changed the base branch from main to ruff-0.7 October 8, 2024 11:36
@MichaReiser MichaReiser added the internal An internal refactor or improvement label Oct 8, 2024
@MichaReiser MichaReiser force-pushed the remove-tab-size-setting branch from 946e791 to b852bca Compare October 8, 2024 11:49
@MichaReiser MichaReiser merged commit 7ac10da into ruff-0.7 Oct 8, 2024
20 checks passed
@MichaReiser MichaReiser deleted the remove-tab-size-setting branch October 8, 2024 12:40
AlexWaygood pushed a commit that referenced this pull request Oct 17, 2024
Co-authored-by: Alex Waygood <[email protected]>
Closes #12041
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration Related to settings and configuration internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants