-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove tab-size setting #12835
Remove tab-size setting #12835
Conversation
b1f98e7
to
dbdfac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's been deprecated for a very long time so I'm okay with removing it, but I also think it would be fine to leave the nice error message there for another minor version. It's not really a maintenance burden 😄
CodSpeed Performance ReportMerging #12835 will not alter performanceComparing Summary
|
|
I consider it a maintenance burden because we consider it for removal in every minor but never go through with it. That's why we should either decide to close the tasks and not remove them until 1.0 (or in ten years when the above argument no longer applies) or to go forward with it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
946e791
to
b852bca
Compare
Co-authored-by: Alex Waygood <[email protected]> Closes #12041
Summary
The
tab-size
setting was deprecated in Ruff 0.1.2 and using it is an error since Ruff 0.5 (#12006).This PR removes the option entirely.
Closes #12041
Test Plan