Formatter: Wrapping Parentheses Different than Black

[juftin]

Summary

Black and Ruff formatted this code differently - I don't think this is a Known Deviation and could't find an similar issue.

Both are readable but I actually prefer what black is doing here on YELLOWSTONE_CAMPSITE_AVAILABILITY and YELLOWSTONE_PROPERTY_INFO. I prefer the variable name and the type annotation on the same line as opposed to the variable name, annotation, and value on three separate lines. I also prefer the parentheses to be around the value instead of the annotation.

I came across the issue when moving from black to ruff on a large code base. Everything else looked perfect!

Original Code

class YellowstoneConfig:
    """
    Yellowstone Variable Storage Class
    """

    API_BASE_PATH: str = "v1/api"
    YELLOWSTONE_PARK_PATH: str = "yellowstonenationalparklodges"
    CAMPSITE_AVAILABILITY: str = f"{API_BASE_PATH}/availability/rooms"
    YELLOWSTONE_CAMPSITE_AVAILABILITY: str = f"{CAMPSITE_AVAILABILITY}/{YELLOWSTONE_PARK_PATH}"
    YELLOWSTONE_PROPERTY_INFO: str = f"{API_BASE_PATH}/property/rooms/{YELLOWSTONE_PARK_PATH}"

Code after black

class YellowstoneConfig:
    """
    Yellowstone Variable Storage Class
    """

    API_BASE_PATH: str = "v1/api"
    YELLOWSTONE_PARK_PATH: str = "yellowstonenationalparklodges"
    CAMPSITE_AVAILABILITY: str = f"{API_BASE_PATH}/availability/rooms"
    YELLOWSTONE_CAMPSITE_AVAILABILITY: str = (
        f"{CAMPSITE_AVAILABILITY}/{YELLOWSTONE_PARK_PATH}"
    )
    YELLOWSTONE_PROPERTY_INFO: str = (
        f"{API_BASE_PATH}/property/rooms/{YELLOWSTONE_PARK_PATH}"
    )

Code After ruff format

Note that both the original and the black code will be changed to this

class YellowstoneConfig:
    """
    Yellowstone Variable Storage Class
    """

    API_BASE_PATH: str = "v1/api"
    YELLOWSTONE_PARK_PATH: str = "yellowstonenationalparklodges"
    CAMPSITE_AVAILABILITY: str = f"{API_BASE_PATH}/availability/rooms"
    YELLOWSTONE_CAMPSITE_AVAILABILITY: (
        str
    ) = f"{CAMPSITE_AVAILABILITY}/{YELLOWSTONE_PARK_PATH}"
    YELLOWSTONE_PROPERTY_INFO: (
        str
    ) = f"{API_BASE_PATH}/property/rooms/{YELLOWSTONE_PARK_PATH}"

Settings

• ruff==0.1.3
• black==23.3.0
• Settings: None

[MichaReiser]

Hey @juftin

I think #8233 should have fixed this and is part of the latest ruff version 0.1.3 (playground).

Can you run ruff version and share the output with us? I'm trying to understand what's going on.

[juftin]

🤦 yep, you're right @MichaReiser. I was using my global ruff which was at 0.0.292 instead of my project's ruff (0.1.3). Everything looks perfect now. Really fantastic work.

[MichaReiser]

Perfect. Thanks for reporting back.