Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rules SIM118 cause autofix error #7124

Closed
qarmin opened this issue Sep 4, 2023 · 1 comment · Fixed by #7150
Closed

Rules SIM118 cause autofix error #7124

qarmin opened this issue Sep 4, 2023 · 1 comment · Fixed by #7150
Assignees
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.

Comments

@qarmin
Copy link

qarmin commented Sep 4, 2023

Ruff 0.0.287 (latest changes from main branch)

ruff  *.py --select SIM118 --no-cache --fix

file content(at least simple cpython script shows that this is valid python file):

class DockerVmManager(VmManager):
		try:U=H.image_from_ami_id(A,verify=_A)
		except InvalidAMIIdError as J:
			if A in B.amis.keys()and B.amis[A].get_filter_value(_H)==_C:LOG.debug(f"Deregistering AMI '{A}' because it no longer exists in Docker");B.amis.pop(A,_B)

error

/home/rafal/test/tmp_folder/1378887.py:4:7: SIM118 Use `A in B.amis` instead of `A in B.amis.keys()`
Found 1 error.

error: Autofix introduced a syntax error. Reverting all changes.

This indicates a bug in `ruff`. If you could open an issue at:

    https://github.com/astral-sh/ruff/issues/new?title=%5BAutofix%20error%5D

...quoting the contents of `/home/rafal/test/tmp_folder/1378887.py`, the rule codes SIM118, along with the `pyproject.toml` settings and executed command, we'd be very appreciative!

python_compressed.zip

@MichaReiser MichaReiser added bug Something isn't working fuzzer Surfaced via fuzzing. labels Sep 4, 2023
@dhruvmanila
Copy link
Member

Again a whitespace problem, we're removing the .keys() method but there's no whitespace between the call and the keyword and, it get's merged into the attribute:

- if A in B.amis.keys()and B.amis[A]
+ if A in B.amisand B.amis[A]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fuzzer Surfaced via fuzzing.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants