PLC0414 conflicts with re-exporting imports in py files

[twoertwein]

Pandas uses similar code in pandas/_typing.py

if TYPE_CHECKING:
    if sys.version_info >= (3, 10):
        from typing import TypeGuard
    else:
        from typing_extensions import TypeGuard
else:
    TypeGuard: Any = None

TypeGuard is not used inside this file (pyright detects this). A fix for pyright is to use the redundant as TypeGuard import but PLC0414 conflicts with that. Alternatives are: ignore the pyright error or create __all__ (but that would need to contain a lot of symbols).

xref #3734 pandas-dev/pandas#54085

[zanieb]

Thanks for the clear issue!

PLC0414 is not enabled by default — perhaps you don't want to use it in Pandas if you need to export names with the redundant as ... or perhaps it'd make sense to disable it in that file?

What do you see as the ideal behavior for Ruff here?

[twoertwein]

Thank you, ignoring this rule (for this one file/or all) is probably the best option.

As far as I remember, flake8's F401 (haven't used it since switching to ruff :) ) also treats explicit re-exports as used imports.

[zanieb]

Yes F401 will be raised on from . import foo but not from . import foo as foo (some discussion on that right now at #5697)

Anything else you can see Ruff doing better here or should we close this?

[twoertwein]

Can be closed.

Anything else you can see Ruff doing better here or should we close this?

(Consider removing this rule.) I will ignore this rule.

[charliermarsh]

Yeah PLC0414 is a strange rule because explicit re-export is a respected mechanism to indicate publicity by many tools (Ruff, but also Pyright).