Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --add-noqa support for Jupyter notebooks #5189

Open
Tracked by #5188
dhruvmanila opened this issue Jun 19, 2023 · 2 comments
Open
Tracked by #5188

Add --add-noqa support for Jupyter notebooks #5189

dhruvmanila opened this issue Jun 19, 2023 · 2 comments
Labels
notebook Related to (Jupyter) notebooks suppression Related to supression of violations e.g. noqa

Comments

@dhruvmanila
Copy link
Member

No description provided.

@dhruvmanila dhruvmanila mentioned this issue Jun 19, 2023
Closed
26 tasks
@dhruvmanila dhruvmanila added core Related to core functionality suppression Related to supression of violations e.g. noqa labels Jun 19, 2023
@dhruvmanila dhruvmanila self-assigned this Jun 20, 2023
@janosh
Copy link

janosh commented Jul 12, 2023 •
edited
Loading

I have a notebook with one violation:

10:88:36: FA102 Missing from __future__ import annotations, but uses PEP 585 collection

I ran

ruff . --add-noqa

which somehow resulted in

Added 171 noqa directives.

which made all notebooks in directory unparsable. Maybe best to bail on this operation until this feature is implemented rather than break notebooks.

@charliermarsh
Copy link
Member

Oh weird, I assumed they were just skipped. Will take a look.

@dhruvmanila dhruvmanila mentioned this issue Jul 13, 2023
Merged
@dhruvmanila dhruvmanila removed their assignment Sep 12, 2023
@dhruvmanila dhruvmanila added notebook Related to (Jupyter) notebooks and removed core Related to core functionality labels Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
notebook Related to (Jupyter) notebooks suppression Related to supression of violations e.g. noqa
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@charliermarsh @janosh @dhruvmanila